update release-it to 17.3.0 and re-release wcl
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the last two times a release of wcl was cut, the code wasn't functional. the code was updated at npmjs.com, but updating the wcl version in the apps where it's being used didn't actually reflect the update. the first time this happened cutting a new release, of the same code, allowed the new code to be used. instead of doing that again, I'm hoping that updating `release-it` will fix this issue going forward.
alishaevn
changed the title
release-it to 17.3.0release-it to 17.3.0 and re-release wcl
attempt to fix the current ci error. the error only appeared on this branch, so I'm assuming it's related to the release-it upgrade. ci error: https://github.com/scientist-softserv/webstore-component-library/actions/runs/9180400953/job/25245089130?pr=231 ``` npm notice npm ERR! code ENEEDAUTH npm ERR! need auth This command requires you to be logged in to https://registry.npmjs.org/ npm ERR! need auth You need to authorize this machine using `npm adduser` npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-21T19_44_34_719Z-debug-0.log Error: Process completed with exit code 1. ```
alishaevn
commented
May 21, 2024
| @@ -13,7 +13,7 @@ jobs: | |||
| # Setup .npmrc file to publish to GitHub Packages | |||
| - uses: actions/setup-node@v3 | |||
| with: | |||
| registry-url: 'https://npm.pkg.github.com' | |||
| registry-url: 'https://registry.npmjs.org' | |||
There was a problem hiding this comment.
reason for this change detailed here.
There was a problem hiding this comment.
thread that led me to this change: npm/cli#6184 (comment)
There was a problem hiding this comment.
0.1.24 was also successfully registered on npmjs.
alishaevn
added a commit
to assaydepot/phenovista-digital-storefront
that referenced
this pull request
May 21, 2024
alishaevn
added a commit
to assaydepot/webstore
that referenced
this pull request
May 21, 2024
labradford
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the last two times a release of wcl was cut, the code wasn't functional. the code was updated at npmjs.com, but updating the wcl version in the apps where it's being used didn't actually reflect the update. the first time this happened cutting a new release, of the same code, allowed the new code to be used.
instead of doing that again, I'm hoping that updating
release-itwill fix this issue going forward.related: