add truncatedLength as an option to card body #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update the Default Item story to show the proper values. Co-authored-by: leaannbradford <ltrammer@gmail.com> - ref: assaydepot/phenovista-digital-storefront#71
alishaevn
suggested changes
May 10, 2024
src/compounds/Item/CardBody.jsx
Outdated
| @@ -26,13 +26,13 @@ const CardBody = ({ buttonLink, buttonProps, item, markdownDescriptionTruncated, | |||
| </Card.Title> | |||
| {orientation === 'horizontal' ? ( | |||
| <> | |||
| <div className='fw-light mh-300 overflow-auto mt-3'> | |||
| <div className='fw-light mh-300 overflow-auto mt-3 testing'> | |||
There was a problem hiding this comment.
Suggested change
| <div className='fw-light mh-300 overflow-auto mt-3 testing'> | |
| <div className='fw-light mh-300 overflow-auto mt-3'> |
src/compounds/Item/CardBody.jsx
Outdated
| @@ -4,7 +4,7 @@ import { Button, Card, Collapse } from 'react-bootstrap' | |||
| import NextLink from '../../components/NextLink/NextLink' | |||
| import LinkedButton from '../LinkedButton/LinkedButton' | |||
|
|
|||
| const CardBody = ({ buttonLink, buttonProps, item, markdownDescriptionTruncated, markdownDescriptionExtended, orientation, titleLink, withButtonLink, withTitleLink }) => { | |||
| const CardBody = ({ buttonLink, buttonProps, item, markdownDescriptionTruncated, markdownDescriptionExtended, truncatedLength, orientation, titleLink, withButtonLink, withTitleLink }) => { | |||
There was a problem hiding this comment.
what do you think about changing this variable name to truncateAt? feels a little more semantic.
also, can you move this to after "titleLink"? the variables are alphabetized.
There was a problem hiding this comment.
Summer called it cutOffIndex. Do you think it makes sense to use that?
There was a problem hiding this comment.
I feel like truncateAt is even more semantic than cutOffIndex...but I'm fine with either.
alishaevn
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to pass in the truncated text length so the showmore toggle only shows according to what you want. Default is set to 300 still.