209-nav-logo-size #210
Merged
209-nav-logo-size #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, wide logo's would overflow the width of the Navbar.Brand. this commit adds height to the brand element, instead of the logo image, containing the logo height and width within the Navbar.Brand. there isn't a bootstrap element that sets height to a specific value. the choice was to use inline styles or create a new class. I opted to create a new class. it's specific to the Header component so it's not in globals.scss. the name "custom-navbar-brand" makes it easier to denote that it's our class and not bootstrap's when inspecting from the browser. - ref: #209
2 tasks
labradford
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story
contain the logo in the navbar
previously, wide logo's would overflow the width of the Navbar.Brand. this commit adds height to the brand element, instead of the logo image, containing the logo height and width within the Navbar.Brand.
there isn't a bootstrap element that sets height to a specific value. the choice was to use inline styles or create a new class. I opted to create a new class. it's specific to the Header component so it's not in globals.scss. the name "custom-navbar-brand" makes it easier to denote that it's our class and not bootstrap's when inspecting from the browser.
demo
example with tall logo
example with wide logo