200 Make Boxes Clickable #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dquote> dquote> -removed clickable link dquote> -wrapped card in clickable link to new request dquote> Co-authored-by: Dalton McAuliffe <dalton.j.mcauliffe97@gmail.com> dquote> Co-authored-by: Adrian Carranza <adriancarranza0113@gmail.com> Ref:#200
summer-cook
reviewed
Feb 1, 2024
src/compounds/Item/Item.jsx
Outdated
| children={( | ||
| <> | ||
| <Image | ||
| className={`cover ${orientation === 'horizontal' ? 'img-fluid h-100 rounded-start' : 'card-img-top'}`} |
There was a problem hiding this comment.
Indent lines 60-62 one more time
alishaevn
suggested changes
Feb 2, 2024
Comment on lines
+22
to
+25
| children: PropTypes.oneOfType([ | ||
| PropTypes.string, | ||
| PropTypes.elementType, | ||
| ]).isRequired, |
alishaevn
approved these changes
Feb 2, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by:Dalton McAuliffe[[dalton.j.mcauliffe97@gmail.com]
Co-authored by:Adrian Carranza[[adriancarranza0113@gmail.com]
Ref: #200
Description
currently, it is not obvious that the featured service links on the homepage are links. the goal is to improve the user experience by making the entire card clickable instead of just the title
User Impact
Users will be able to click the whole car to a new request instead of only clinking the title.
Instructions
go to website home page click on cards on the homepage and cards will take you to the desired request