remove non-used tests

arzonus · Jan 6, 2025 · eb558cd · eb558cd
1 parent dd57921
commit eb558cd
Showing 1 changed file with 0 additions and 83 deletions.
diff --git a/service/history/workflowcache/cache_test.go b/service/history/workflowcache/cache_test.go
@@ -223,89 +223,6 @@ func TestWfCache_AllowDomainCacheError(t *testing.T) {
 	logger.AssertExpectations(t)
 }
 
-// TestWfCache_CacheExternalDisabled tests that the cache will allow requests only for the requests where it is enabled
-func TestWfCache_CacheExternalDisabled(t *testing.T) {
-	ctrl := gomock.NewController(t)
-
-	domainCache := cache.NewMockDomainCache(ctrl)
-	domainCache.EXPECT().GetDomainName(testDomainID).Return(testDomainName, nil).Times(2)
-
-	// Setup the mock logger
-	logger := new(log.MockLogger)
-	expectRatelimitLog(logger, "internal", "enabled")
-
-	externalLimiterFactory := quotas.NewMockLimiterFactory(ctrl)
-	externalLimiter := quotas.NewMockLimiter(ctrl)
-	externalLimiterFactory.EXPECT().GetLimiter(testDomainName).Return(externalLimiter).Times(1)
-
-	internalLimiter := quotas.NewMockLimiter(ctrl)
-	internalLimiterFactory := quotas.NewMockLimiterFactory(ctrl)
-	internalLimiterFactory.EXPECT().GetLimiter(testDomainName).Return(internalLimiter).Times(1)
-
-	internalLimiter.EXPECT().Allow().Return(false).Times(1)
-
-	wfCache := New(Params{
-		TTL:                            time.Minute,
-		MaxCount:                       1_000,
-		ExternalLimiterFactory:         externalLimiterFactory,
-		InternalLimiterFactory:         internalLimiterFactory,
-		Logger:                         logger,
-		DomainCache:                    domainCache,
-		MetricsClient:                  metrics.NewNoopMetricsClient(),
-		RatelimitExternalPerWorkflowID: func(domain string) bool { return false },
-		RatelimitInternalPerWorkflowID: func(domain string) bool { return true },
-	})
-
-	// We fail open
-	assert.True(t, wfCache.AllowExternal(testDomainID, testWorkflowID))
-
-	// We use cache
-	assert.False(t, wfCache.AllowInternal(testDomainID, testWorkflowID))
-
-	// We log the error
-	logger.AssertExpectations(t)
-}
-
-// TestWfCache_CacheInternalDisabled tests that the cache will allow requests only for the requests where it is enabled
-func TestWfCache_CacheInternalDisabled(t *testing.T) {
-	ctrl := gomock.NewController(t)
-
-	domainCache := cache.NewMockDomainCache(ctrl)
-	domainCache.EXPECT().GetDomainName(testDomainID).Return(testDomainName, nil).Times(2)
-
-	// Setup the mock logger
-	logger := new(log.MockLogger)
-	expectRatelimitLog(logger, "external", "enabled")
-
-	externalLimiterFactory := quotas.NewMockLimiterFactory(ctrl)
-	externalLimiter := quotas.NewMockLimiter(ctrl)
-	externalLimiterFactory.EXPECT().GetLimiter(testDomainName).Return(externalLimiter).Times(1)
-	externalLimiter.EXPECT().Allow().Return(false).Times(1)
-	internalLimiter := quotas.NewMockLimiter(ctrl)
-	internalLimiterFactory := quotas.NewMockLimiterFactory(ctrl)
-	internalLimiterFactory.EXPECT().GetLimiter(testDomainName).Return(internalLimiter).Times(1)
-
-	wfCache := New(Params{
-		TTL:                            time.Minute,
-		MaxCount:                       1_000,
-		ExternalLimiterFactory:         externalLimiterFactory,
-		InternalLimiterFactory:         internalLimiterFactory,
-		Logger:                         logger,
-		DomainCache:                    domainCache,
-		MetricsClient:                  metrics.NewNoopMetricsClient(),
-		RatelimitExternalPerWorkflowID: func(domain string) bool { return true },
-		RatelimitInternalPerWorkflowID: func(domain string) bool { return false },
-	})
-
-	// We use cache
-	assert.False(t, wfCache.AllowExternal(testDomainID, testWorkflowID))
-	// We fail open
-	assert.True(t, wfCache.AllowInternal(testDomainID, testWorkflowID))
-
-	// We log the error
-	logger.AssertExpectations(t)
-}
-
 func TestWfCache_RejectLog(t *testing.T) {
 	ctrl := gomock.NewController(t)