Skip to content

Commit

Permalink
More whitespace changes
Browse files Browse the repository at this point in the history
  • Loading branch information
eflumerf committed Feb 18, 2025
1 parent eecaa49 commit ad5445c
Show file tree
Hide file tree
Showing 40 changed files with 275 additions and 282 deletions.
7 changes: 3 additions & 4 deletions .clang-format
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ AlwaysBreakBeforeMultilineStrings: true
AlwaysBreakTemplateDeclarations: true
BinPackArguments: true
BinPackParameters: true
BraceWrapping:
BraceWrapping:
AfterClass: true
AfterControlStatement: true
AfterEnum: true
Expand Down Expand Up @@ -54,11 +54,11 @@ DerivePointerAlignment: true
DisableFormat: false
ExperimentalAutoDetectBinPacking: false
FixNamespaceComments: true
ForEachMacros:
ForEachMacros:
- foreach
- Q_FOREACH
- BOOST_FOREACH
IncludeCategories:
IncludeCategories:
- Regex: '^<.*\.h>'
Priority: 1
- Regex: '^<.*'
Expand Down Expand Up @@ -105,4 +105,3 @@ Standard: Auto
TabWidth: 4
UseTab: ForIndentation
...

2 changes: 1 addition & 1 deletion .github/workflows/artdaq-build-single-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Build Single Pkg Workflow

on:
push:
branches:
branches:
- develop
paths-ignore:
- 'docs/**'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/artdaq-develop-cpp-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: build-develop
# or API.
on:
push:
branches-ignore:
branches-ignore:
- develop
- stable
paths-ignore:
Expand All @@ -20,5 +20,5 @@ on:

jobs:
build_against_dev_release:
name: Build against develop
uses: art-daq/.github/.github/workflows/artdaq-develop-cpp-ci.yml@stable
name: Build against develop
uses: art-daq/.github/.github/workflows/artdaq-develop-cpp-ci.yml@stable
2 changes: 1 addition & 1 deletion .github/workflows/artdaq-format-single-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Format Single Pkg Workflow

on:
push:
branches:
branches:
- develop
paths-ignore:
- 'docs/**'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/artdaq-test-single-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Test Single Pkg Workflow

on:
push:
branches:
branches:
- develop
paths-ignore:
- 'docs/**'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/artdaq-tidy-single-pkg.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Tidy Single Pkg Workflow

on:
push:
branches:
branches:
- develop
paths-ignore:
- 'docs/**'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto_approve.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Auto approve

on:
workflow_dispatch:
inputs:
inputs:
pullRequestNumber:
description: Pull request number to auto-approve
required: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/git-whitespace.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Git Whitespace Check Workflow

on:
push:
branches:
branches:
- develop
paths-ignore:
- 'docs/**'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/track_new_issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
}' -f org=$ORGANIZATION -F number=$PROJECT_NUMBER > project_data.json
echo 'PROJECT_ID='$(jq '.data.organization.projectV2.id' project_data.json) >> $GITHUB_ENV
- name: Add issue to project
env:
GITHUB_TOKEN: ${{ secrets.BOT_CI_ISSUES }}
Expand All @@ -37,4 +37,4 @@ jobs:
id
}
}
}' -f project=$PROJECT_ID -f issue=$ISSUE_ID --jq '.data.addProjectV2ItemById.item.id')"
}' -f project=$PROJECT_ID -f issue=$ISSUE_ID --jq '.data.addProjectV2ItemById.item.id')"
4 changes: 2 additions & 2 deletions .github/workflows/track_new_prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
}' -f org=$ORGANIZATION -F number=$PROJECT_NUMBER > project_data.json
echo 'PROJECT_ID='$(jq '.data.organization.projectV2.id' project_data.json) >> $GITHUB_ENV
- name: Add issue to project
env:
GITHUB_TOKEN: ${{ secrets.BOT_CI_ISSUES }}
Expand All @@ -37,4 +37,4 @@ jobs:
id
}
}
}' -f project=$PROJECT_ID -f issue=$node_id --jq '.data.addProjectV2ItemById.item.id')"
}' -f project=$PROJECT_ID -f issue=$node_id --jq '.data.addProjectV2ItemById.item.id')"
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ cet_set_compiler_flags(DIAGS VIGILANT
NO_UNDEFINED
EXTRA_FLAGS -pedantic
)

# Debug streamer.
string(TOUPPER ${CMAKE_BUILD_TYPE} BTYPE_UC)
if(BTYPE_UC STREQUAL DEBUG)
Expand Down
13 changes: 6 additions & 7 deletions CreateNewFragmentGenerator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@
require 'fileutils'

if ARGV.length != 2
puts "Usage: " + __FILE__ + " <Fragment generator token> <Fragment token>"
puts "Usage: " + __FILE__ + " <Fragment generator token> <Fragment token>"
exit 1
end

fraggentoken = ARGV[0]
fragtoken = ARGV[1]

if ! ENV['ARTDAQDEMO_REPO']
if ! ENV['ARTDAQDEMO_REPO']
puts "Couldn\'t find ARTDAQDEMO_REPO variable; have you sourced setupARTDAQDEMO?"
exit 1
end

basedir = ENV['ARTDAQDEMO_REPO']
basedir = ENV['ARTDAQDEMO_REPO']
gendir = basedir + "/artdaq-demo/Generators/"
overlaydir = basedir + "/artdaq-demo/Overlays/"

Expand Down Expand Up @@ -55,19 +55,18 @@
# Add in the new generator to the CMakeLists.txt file for compilation

sourcetext = File.read( gendir + "CMakeLists.txt" )
sourcetext += "\n\n"
sourcetext += "\n\n"
sourcetext += "simple_plugin(" + fraggentoken + " \"generator\"\n"
sourcetext += <<-'EOS'
artdaq-demo_Overlays
artdaq_Application
artdaq_DAQdata
artdaq_Utilities
art_Utilities
${FHICLCPP}
${CETLIB}
${FHICLCPP}
${CETLIB}
)
EOS

outf = File.open( gendir + "CMakeLists.txt", 'w')
outf.puts sourcetext

6 changes: 3 additions & 3 deletions artdaq-demo/ArtModules/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
include(BuildPlugins) # Art Module

cet_build_plugin(ArtdaqDemoBuildInfo art::module
LIBRARIES REG
cet_build_plugin(ArtdaqDemoBuildInfo art::module
LIBRARIES REG
TRACE::MF
artdaq_demo::artdaq-demo_BuildInfo
artdaq_core::artdaq-core_BuildInfo
Expand All @@ -22,7 +22,7 @@ cet_build_plugin(WFViewer art::module LIBRARIES REG artdaq_core_demo::artdaq-cor
cet_build_plugin(DemoViewer art::module LIBRARIES REG artdaq_core_demo::artdaq-core-demo_Overlays ROOT::Core ROOT::Gui)

cet_build_plugin(CheckIntegrity art::module LIBRARIES REG artdaq_core_demo::artdaq-core-demo_Overlays)

cet_build_plugin(EventReporterOutput art::module LIBRARIES REG artdaq::DAQdata ROOT::Core artdaq_core::artdaq-core_Data_ParentageMap)

install_headers(SUBDIRS detail)
Expand Down
10 changes: 5 additions & 5 deletions artdaq-demo/BuildInfo/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ string( STRIP ${rawUTCDate} utcDateTime )

execute_process(COMMAND git describe --tags
WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
RESULT_VARIABLE GIT_DESCRIBE_RESULT
OUTPUT_VARIABLE GIT_DESCRIBE_VERSION
ERROR_QUIET
RESULT_VARIABLE GIT_DESCRIBE_RESULT
OUTPUT_VARIABLE GIT_DESCRIBE_VERSION
ERROR_QUIET
OUTPUT_STRIP_TRAILING_WHITESPACE)

message("${GIT_DESCRIBE_RESULT}: ${GIT_DESCRIBE_VERSION} || $ENV{CETPKG_VERSION}")
Expand All @@ -42,10 +42,10 @@ configure_file ( ${CMAKE_CURRENT_SOURCE_DIR}/GetPackageBuildInfo.cc.in
${CMAKE_CURRENT_BINARY_DIR}/GetPackageBuildInfo.cc @ONLY )

cet_make_library( LIBRARY_NAME artdaq-demo_BuildInfo
SOURCE
SOURCE
${CMAKE_CURRENT_BINARY_DIR}/GetPackageBuildInfo.cc
LIBRARIES artdaq_core::artdaq-core_Data
)
)

install_headers()
install_source()
1 change: 0 additions & 1 deletion artdaq-demo/BuildInfo/GetPackageBuildInfo.cc.in
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ namespace demo {
}

}

15 changes: 7 additions & 8 deletions artdaq-demo/Generators/ToyHardwareInterface/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
cet_make_library(
SOURCE
ToyHardwareInterface.cc
LIBRARIES
artdaq::DAQdata
SOURCE
ToyHardwareInterface.cc
LIBRARIES
artdaq::DAQdata
artdaq_core::artdaq-core_Data
artdaq_core_demo::artdaq-core-demo_Overlays

)

)

install_headers()
install_source()
install_source()
6 changes: 2 additions & 4 deletions tools/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,9 @@ cet_make_exec(NAME read_fhicl SOURCE readfhicl.cc
LIBRARIES
fhiclcpp::fhiclcpp
Boost::program_options
)
)

# Is this necessary?
#install_source()
install_fhicl(SUBDIRS fcl)
install_headers()
install_source()

2 changes: 1 addition & 1 deletion tools/fcl/driver_test3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ buffer_count: 20

art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/driver_test4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ buffer_count: 20

art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx3000000_nodisk3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx300000_nodisk4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_binbuf3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_binbuf4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_bindirect3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_binnull3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_binnull4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_root2.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_root3.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_root3null.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_10Mx30000_root4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
2 changes: 1 addition & 1 deletion tools/fcl/test_1Mx300000_binnull4.fcl
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ metrics: {
######################################################################
art: {
services: {
ArtdaqSharedMemoryServiceInterface: {
ArtdaqSharedMemoryServiceInterface: {
service_provider: ArtdaqSharedMemoryService
waiting_time: 900
resume_after_timeout: true
Expand Down
Loading

0 comments on commit ad5445c

Please sign in to comment.