Make building Scala client work on Github Actions #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EnricoMi
commented
Feb 10, 2025
| @@ -19,6 +19,7 @@ RUN set -ex && \ | |||
| apt-get clean && \ | |||
| rm -rf scala-${SCALA_VERSION}.deb sbt-${SBT_VERSION}.tgz /var/lib/apt/lists/* | |||
|
|
|||
| ENV PATH="/sbt/bin:$PATH" | |||
There was a problem hiding this comment.
The Dockerfile installs sbt to this location, so it should deal with setting PATH, not the build script.
| @@ -32,5 +32,6 @@ func BuildScala() error { | |||
| "--rm", | |||
| "-v", fmt.Sprintf("%s:/build", wd), | |||
| "-w", "/build", | |||
| "--env", "HOME=/tmp", | |||
There was a problem hiding this comment.
Running as part of the Github Actions CI, default HOME will point to a location (/) where the user (probably the test runner user) running the build script does not have write permissions. This home works for any user running the script in the Docker container.
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
Signed-off-by: Enrico Minack <github@enrico.minack.dev>
EnricoMi
force-pushed
the
scala-build-container-integration
branch
from
dbb921c to
0b96edb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Fixing CI.
What this PR does / why we need it:
Fixes running
mage buildScalaon Github Actions as part of CI.Which issue(s) this PR fixes:
Minor fix.