fix!: make .spec.selector immutable
#4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Published E2E Test Results 4 files 4 suites 3h 8m 46s ⏱️ For more details on these failures, see this check. Results for commit 639a6fc. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 291 tests 2 291 ✅ 2m 59s ⏱️ Results for commit 639a6fc. ♻️ This comment has been updated with latest results. |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
|
zachaller
changed the title
zachaller
changed the title
zachaller
changed the title
.spec.selector immutable
agaudreault
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
LGTM. The PR could be titled fix!: <desc> to clearly identify a breaking change. https://www.conventionalcommits.org/en/v1.0.0/
zachaller
changed the title
.spec.selector immutable.spec.selector immutable
2 tasks
6 tasks
meeech
pushed a commit
to CircleCI-Public/argo-rollouts
that referenced
this pull request
Feb 10, 2025
* fix: make selector immutable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: make selector immutable Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: make selector optional for workloadRef Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
We are changing the behavior of Rollouts
.spec.selectorto be immutable. This change matches the behavior of the Deployment kind which is a goal of the Rollouts kind to stay as close as possible to the Deployment resource. This change fixes issues and confusion when we abandon ReplicaSets if the selector is change. Going forward in order to change the selector you would have to delete the Rollout.Upstream Reference: kubernetes/kubernetes#50808
fixes: #1761, #2105, #4070