Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): Analyse past release times #3135

Merged
merged 4 commits into from
Jan 29, 2025
Merged

feat(github): Analyse past release times #3135

merged 4 commits into from
Jan 29, 2025

Conversation

tico24
Copy link
Member

@tico24 tico24 commented Jan 24, 2025

I'm far from a python expert so please don't laugh too much.

I wanted to understand whether or not we are releasing at a faster pace than before (given we are a more organised team and we have automation in the likes of Renovate now).

This script calculates the release time for each upstream release and plots the values on a graph.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
Signed-off-by: Tim Collins <tim@thecollins.team>
@mkilchhofer
Copy link
Member

I'm far from a python expert so please don't laugh too much.

Sadly my python knowhow is even worse :D I totally missed that Python era - I am still on pure bash or Go ^^

Shall we present the output of this on the GH pages over there?
https://argoproj.github.io/argo-helm/ (maybe under /stats or so)

@tico24
Copy link
Member Author

tico24 commented Jan 24, 2025

Shall we present the output of this on the GH pages over there?

short answer is “yes, eventually, but not in this PR”.

We should use gha to build the data as we go rather than this expensive query for the whole history. Once we have that then we can look into publishing.

@tico24
Copy link
Member Author

tico24 commented Jan 29, 2025

Could I get some reviews please?

@mkilchhofer
Copy link
Member

Could I get some reviews please?

I am okay with that :) 👍
Do the Argoproj maintainers have any plans on the SLA? I saw the SLA graph and I am curious if it is only an assumption by you ( @tico24 ) or if it comes from the project.

@tico24
Copy link
Member Author

tico24 commented Jan 29, 2025

The SLA comes from a time that @jmeridth told me. But I can't find it written anywhere.

@mkilchhofer
Copy link
Member

@tico24 maybe documentation regarding what permissions the PAT requires would be nice, WDYT?

@tico24
Copy link
Member Author

tico24 commented Jan 29, 2025

Ah yeh I'll do that. It just needs public read, so super minimal.

@mkilchhofer
Copy link
Member

mkilchhofer commented Jan 29, 2025

Do we have a explanation why we have two negative data points?
image

@tico24
Copy link
Member Author

tico24 commented Jan 29, 2025

Do we have a explanation why we have two negative data points?

(that negative number for argocd is somehow correct... I released the helm chart before the upstream version was released... I have no idea why).

https://cloud-native.slack.com/archives/C0574J7GR5Z/p1737707991527589

@yu-croco yu-croco enabled auto-merge (squash) January 29, 2025 13:42
@yu-croco yu-croco merged commit 56c5a31 into main Jan 29, 2025
6 checks passed
@yu-croco yu-croco deleted the release-analysis branch January 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants