-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(argo-rollouts): Add missing patch permissions for contour RBAC #2452
Conversation
Since this PR argoproj-labs/rollouts-plugin-trafficrouter-contour#53 the contour trafficrouter plugin uses `patch` not `update`. Add the `patch` permission so that the latest version of the trafficrouter plugin works Signed-off-by: Frank Hamand <frankhamand@gmail.com>
We match the releases. The latest release does not include that PR. https://github.com/argoproj/argo-rollouts/releases/tag/v1.6.4 |
It's from the plugin, not argo, and it is in the latest release: https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-contour/tree/v0.3.0 |
@@ -266,6 +266,7 @@ rules: | |||
- list | |||
- watch | |||
- update | |||
- patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's from the plugin, not argo, and it is in the latest release: https://github.com/argoproj-labs/rollouts-plugin-trafficrouter-contour/tree/v0.3.0
Since this block is for contour not for trafficrouter-contour, I wonder we can provide other block for trafficRouterPlugins, like below? 🤔
{{- if .Values.controller.trafficRouterPlugins }}
- apiGroups:
- projectcontour.io
resources:
- httpproxies
verbs:
- patch
{{- end }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my bad, countor means rollouts-plugin-trafficrouter-contour
. 💡 Please disregard above.
https://github.com/argoproj/argo-helm/blob/main/charts/argo-rollouts/values.yaml#L272-L273
Ah as @jmeridth mentioned, upstream has no permission for contour though there are permissions for other providers. @frankh |
Since this PR argoproj-labs/rollouts-plugin-trafficrouter-contour#53 the contour trafficrouter plugin uses
patch
notupdate
.Add the
patch
permission so that the latest version of the trafficrouter plugin worksChecklist: