chore(argo-cd): Remove deprecated features and redesign Ingress #2407

pdrastil · 2024-01-01T15:11:44Z

It's more than 1 year since these were removed / deprecated and it's probably safe to drop backward compatibility.

Checklist:

I have bumped the chart version according to versioning
I have updated the documentation according to documentation
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Any new values are backwards compatible and/or have sensible default.
I have signed off all my commits as required by DCO.
My build is green (troubleshooting builds).

mkilchhofer · 2024-01-01T16:11:42Z

charts/argo-cd/templates/argocd-application-controller/statefulset.yaml

@@ -13,8 +13,6 @@ metadata:
    {{- include "argo-cd.labels" (dict "context" . "component" .Values.controller.name "name" .Values.controller.name) | nindent 4 }}
 spec:
  replicas: {{ .Values.controller.replicas }}
-  # TODO: Remove for breaking release as history limit cannot be patched
-  revisionHistoryLimit: 5


If we drop this (and I'd sponsor to do so), we need a major bump and also instructions on howto upgrade.

It's mentioned in README that you need to use replace strategy (helm upgrade --force or helm template | kubectl replace -f -)

Helm upgrade force does not work anymore with helmv3+:

Upgrade to Argo-rollouts v2 fails #970

But ok, we can release that👍

@mkilchhofer I'm going to port also #2415 into this as change in Ingress interface will be breaking

Changed to configuration in values.yaml to allow upgrade without replacing the resource based on discussion with @mkilchhofer

charts/argo-cd/Chart.yaml

pdrastil · 2024-01-01T16:21:49Z

@mkilchhofer If we want to do major bump - do we want to go through arguments and name things consistently across components. env, envFrom vs extraArgs. We originally used the extra word because args were dictionary and not a list.

yu-croco

🚀

It's still under discussion

pdrastil · 2024-01-01T16:32:41Z

Also another thing that might go into major release is the changes I've mentioned about multiple ingress controller implementations on Slack. Could be good opportunity to clean this up.

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

pdrastil · 2024-01-30T10:57:14Z

@mkilchhofer Are you OK with current state? Merge is blocked since your last review.

* main: docs(argo-workflows): update documentation links to readthedocs (argoproj#2472) chore(argo-cd): Update dependency argoproj/argo-cd to v2.9.6 (argoproj#2473) fix(argocd-apps): move ignoreApplicationDifferences block up a level (argoproj#2471) fix(argo-cd): bump dex image version to fix cves (argoproj#2468) feat(argo-cd): bump redis deps to fix cves (argoproj#2466)

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* origin/main: chore(argo-cd): refresh from upstream (argoproj#2474)

charts/argo-cd/values.yaml

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

* main: feat(argo-cd): Add Probes for redis (argoproj#2400)

* main: feat(argo-cd): Upgrade Argo CD to 2.10.0 (argoproj#2476)

jetersen · 2024-02-13T07:02:54Z

Release note did not describe to what degree was changed nor provide an upgrade guide 😓
I read the release notes thinking you only changed grpc ingress but even the normal ingress broke because of the use of hostname which seems unconventional. Very common to use hosts
Now left to figure out what changes I had not migrated over the years.

pdrastil · 2024-02-13T08:40:50Z

@jetersen Hi thanks for feedback. I'll add additional info to release notes. I agree that hostname is uncommon, however it makes sense as all components share single domain and some configuration options (SSO, notifications) allow only single URL for callbacks. There is upcoming PR #2499 that simplifies configuration of all services with this cross-cutting concern from single place and user config will look more like this sample, instead of copy & pasting same value into multiple places.

global:
  domain: argocd.example.com

server:
  certificate:
    enabled: true
  ingress:
    enabled: true
    tls: true

pdrastil · 2024-02-13T10:49:43Z

@jetersen Have you seen this or you checked release notes that are part of the chart? https://github.com/argoproj/argo-helm/tree/main/charts/argo-cd#600

jetersen · 2024-02-13T14:39:27Z

Usually Renovate will pull the changelogs from ArtifactHub but because your pushing GitHub Releases as well Renovate will basically grab that first and therefore I did not see the changelog. Yes it is on me for just trusting GitHub Releases since I missed that you maintain the changelog in README.md
I wonder why the GitHub Releases do not contain the content from the changelog.md from the current release.
Shouldn't just be a part of the github workflow for releasing? 🤔

…ifications controller These are deprecated in favor of corresponding settings in `config.params`, to match with the official docs: https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-cmd-params-cm-yaml/ The same changes were previously done for all other components much earlier in argoproj#1267 and then these params were removed in argoproj#2407

…ifications controller These are deprecated in favor of corresponding settings in `config.params`, to match with the official docs: https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-cmd-params-cm-yaml/ The same changes were previously done for all other components much earlier in argoproj#1267 and then these params were removed in argoproj#2407 Signed-off-by: Mikhail Zholobov <legal90@gmail.com>

…ifications controller (#3209) * fix(argo-cd): Deprecate logLevel and logFormat values for dex and notifications controller These are deprecated in favor of corresponding settings in `config.params`, to match with the official docs: https://argo-cd.readthedocs.io/en/stable/operator-manual/argocd-cmd-params-cm-yaml/ The same changes were previously done for all other components much earlier in #1267 and then these params were removed in #2407 Signed-off-by: Mikhail Zholobov <legal90@gmail.com> * chore(argo-cd): Bump argo-cd chart version Signed-off-by: Mikhail Zholobov <legal90@gmail.com> --------- Signed-off-by: Mikhail Zholobov <legal90@gmail.com>

pdrastil requested review from mbevc1, mkilchhofer, yu-croco, jmeridth and tico24 as code owners January 1, 2024 15:11

github-actions bot added argo-cd size/L labels Jan 1, 2024

tico24 approved these changes Jan 1, 2024

View reviewed changes

pdrastil force-pushed the feature/depracate branch 3 times, most recently from 875045a to 393f0dd Compare January 1, 2024 16:06

mkilchhofer reviewed Jan 1, 2024

View reviewed changes

charts/argo-cd/Chart.yaml Outdated Show resolved Hide resolved

pdrastil force-pushed the feature/depracate branch 3 times, most recently from 3c11a73 to 272ec08 Compare January 1, 2024 16:17

yu-croco previously approved these changes Jan 1, 2024

View reviewed changes

yu-croco self-requested a review January 1, 2024 16:24

mbevc1 approved these changes Jan 2, 2024

View reviewed changes

yu-croco approved these changes Jan 3, 2024

View reviewed changes

chore(argo-cd): Remove deprecated features

4409ee0

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

pdrastil force-pushed the feature/depracate branch from 272ec08 to 4409ee0 Compare January 21, 2024 14:11

mkilchhofer approved these changes Jan 21, 2024

View reviewed changes

mbevc1 approved these changes Jan 21, 2024

View reviewed changes

pdrastil added 3 commits January 21, 2024 17:04

Remove wildcard catch all ingress rule

4608d76

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Add ingress extra rules

85198a7

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Remove unnecessary ingress variables

3a8f1e5

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Merge branch 'main' into feature/depracate

afb7f6c

pdrastil requested a review from mkilchhofer January 30, 2024 10:21

pdrastil mentioned this pull request Feb 1, 2024

Argo-CD Role/ClusterRole templates are rendered according to undocumented and confusing Values #2470

Closed

pdrastil added 4 commits February 3, 2024 12:38

Add revisionHistoryLimit for controller

a79081f

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Update README

99aa7a0

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Merge remote-tracking branch 'origin/main' into feature/depracate

ec12429

* origin/main: chore(argo-cd): refresh from upstream (argoproj#2474)

jmeridth reviewed Feb 6, 2024

View reviewed changes

charts/argo-cd/values.yaml Show resolved Hide resolved

pdrastil added 3 commits February 7, 2024 02:08

Update README

accfbfc

Signed-off-by: Petr Drastil <petr.drastil@gmail.com>

Merge branch 'main' into feature/depracate

2332616

* main: feat(argo-cd): Add Probes for redis (argoproj#2400)

Merge branch 'main' into feature/depracate

413c0b3

* main: feat(argo-cd): Upgrade Argo CD to 2.10.0 (argoproj#2476)

jmeridth approved these changes Feb 7, 2024

View reviewed changes

mkilchhofer approved these changes Feb 7, 2024

View reviewed changes

mbevc1 merged commit b8212e0 into argoproj:main Feb 7, 2024

pdrastil mentioned this pull request Feb 8, 2024

chore(argo-cd): Remove wildcard catch all ingress rule #2415

Closed

6 tasks

pdrastil deleted the feature/depracate branch February 8, 2024 09:45

lentidas mentioned this pull request Jun 4, 2024

feat(chart)!: major update of dependencies on argocd chart camptocamp/devops-stack-module-argocd#106

Merged

3 tasks

purajit mentioned this pull request Dec 12, 2024

Breaking changes should be labelled as such #3077

Closed

legal90 mentioned this pull request Mar 21, 2025

fix(argo-cd): Deprecate logLevel and logFormat values for dex and notifications controller #3209

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(argo-cd): Remove deprecated features and redesign Ingress #2407

chore(argo-cd): Remove deprecated features and redesign Ingress #2407

pdrastil commented Jan 1, 2024

mkilchhofer Jan 1, 2024

pdrastil Jan 1, 2024

mkilchhofer Jan 21, 2024

pdrastil Jan 21, 2024

pdrastil Feb 6, 2024

pdrastil commented Jan 1, 2024 •

edited

Loading

yu-croco left a comment

pdrastil commented Jan 1, 2024

pdrastil commented Jan 30, 2024

jetersen commented Feb 13, 2024 •

edited

Loading

pdrastil commented Feb 13, 2024

pdrastil commented Feb 13, 2024

jetersen commented Feb 13, 2024 •

edited

Loading

chore(argo-cd): Remove deprecated features and redesign Ingress #2407

chore(argo-cd): Remove deprecated features and redesign Ingress #2407

Conversation

pdrastil commented Jan 1, 2024

mkilchhofer Jan 1, 2024

Choose a reason for hiding this comment

pdrastil Jan 1, 2024

Choose a reason for hiding this comment

mkilchhofer Jan 21, 2024

Choose a reason for hiding this comment

pdrastil Jan 21, 2024

Choose a reason for hiding this comment

pdrastil Feb 6, 2024

Choose a reason for hiding this comment

pdrastil commented Jan 1, 2024 • edited Loading

yu-croco left a comment

Choose a reason for hiding this comment

pdrastil commented Jan 1, 2024

pdrastil commented Jan 30, 2024

jetersen commented Feb 13, 2024 • edited Loading

pdrastil commented Feb 13, 2024

pdrastil commented Feb 13, 2024

jetersen commented Feb 13, 2024 • edited Loading

pdrastil commented Jan 1, 2024 •

edited

Loading

jetersen commented Feb 13, 2024 •

edited

Loading

jetersen commented Feb 13, 2024 •

edited

Loading