PE-7765: Add Balances Page #180
Conversation
|
Visit the preview URL for this PR (updated for commit 5be8153): https://ar-io-network-portal-a40ee--pr180-pe-7765-add-balances-5ktc171r.web.app (expires Fri, 21 Mar 2025 18:13:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7abfae09c4446982a71cbb94b0cbf4688377a111 |
| process.env.VITE_GATEWAY_HOST ?? 'arweave.net'; | ||
|
|
||
| export const DEFAULT_ARWEAVE_GQL_ENDPOINT = |
There was a problem hiding this comment.
is this an available setting? may be good to add, but can be done in a separate PR
There was a problem hiding this comment.
Not a setting in the settings panel right now. Separate PR to add this sounds good to me.
There was a problem hiding this comment.
Went ahead and added this to settings
Co-authored-by: Dylan Fiedler <dtfiedler@users.noreply.github.com>
src/App.tsx
Outdated
| const BalancesMain = React.lazy(() => import('./pages/Balances')); | ||
| const Balances = React.lazy(() => import('./pages/Balances/Balances')); |
There was a problem hiding this comment.
Lil confusing, maybe like "AllBalances" and "UserBalances", or "Balances" and "BalancesForAddress" or something
There was a problem hiding this comment.
I couldn't figure out a good name yesterday but I like BalancesForAddress so have updated to that.
src/hooks/useReports.ts
Outdated
| @@ -62,7 +62,7 @@ const useReports = (ownerId?: string, gateway?: AoGateway) => { | |||
| if (keys.length > 0) { | |||
| // Epoch pruning on contract means we have at most 14 reports. Retrieve as a batch here. | |||
| const transactions = await arweaveGraphql( | |||
| `https://${DEFAULT_ARWEAVE_HOST}/graphql`, | |||
| DEFAULT_ARWEAVE_GQL_ENDPOINT, | |||
There was a problem hiding this comment.
recomment putting this in global state and using that var, then when we come back and may it adjustable these don't need to be updated again.
There was a problem hiding this comment.
Went ahead and added this to settings
src/hooks/useVaults.ts
Outdated
| queryKey: ['vaults', arioReadSDK], | ||
| queryFn: async () => { | ||
| if (!arioReadSDK) | ||
| throw new Error('arIOReadSDK or walletAddress is not initialized'); |
There was a problem hiding this comment.
nit: not using walletAddress here
src/pages/Balances/Balances.tsx
Outdated
| const walletAddress = params?.walletAddress; | ||
|
|
||
| const walletAddressData = useMemo(() => { | ||
| return walletAddress == undefined |
There was a problem hiding this comment.
can simplify to !isAoAddress(walletAddress) ? undefined : ... eth/arweave logic
Or, might be worth have a util for new AoAddress() which handles this logic
There was a problem hiding this comment.
Could do that here since isAOAddress checks against ArweaveTransactionId and not string. It's a bit quirky and may try to get rid of ArweaveTransactionId in the future and replace with type guard that uses string.
src/pages/Balances/Balances.tsx
Outdated
| <BalancesHeader walletAddress={walletAddress} /> | ||
| {walletAddressData ? ( | ||
| <> | ||
| <Banner walletAddress={walletAddressData} /> | ||
| <VaultsTable walletAddress={walletAddressData} /> |
There was a problem hiding this comment.
nit: inconsistent support of types on like named parameters
…ts' of github.com:ar-io/network-portal into PE-7765-add-balances-page-for-viewing-balances-and-vaults
kunstmusik
deleted the
PE-7765-add-balances-page-for-viewing-balances-and-vaults
branch
No description provided.