Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): remove unsupported code start plugins + fix all open salt severity to critical #2130

Merged
merged 7 commits into from
Feb 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions exports.js
Original file line number Diff line number Diff line change
Expand Up @@ -621,9 +621,6 @@ module.exports = {
'buildProjectEnvPriviligedMode' : require(__dirname + '/plugins/aws/codebuild/buildProjectEnvPriviligedMode.js'),
'codebuildProjectLoggingEnabled': require(__dirname + '/plugins/aws/codebuild/codebuildProjectLoggingEnabled.js'),

'codestarValidRepoProviders' : require(__dirname + '/plugins/aws/codestar/codestarValidRepoProviders.js'),
'codestarHasTags' : require(__dirname + '/plugins/aws/codestar/codestarHasTags.js'),

'pipelineArtifactsEncrypted' : require(__dirname + '/plugins/aws/codepipeline/pipelineArtifactsEncrypted.js'),

'dataStoreEncrypted' : require(__dirname + '/plugins/aws/healthlake/dataStoreEncrypted.js'),
Expand Down
2 changes: 1 addition & 1 deletion plugins/alibaba/ecs/openSalt.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
title: 'Open Salt',
category: 'ECS',
domain: 'Compute',
severity: 'Medium',
severity: 'Critical',
description: 'Ensure that security groups does not have TCP ports 4505 or 4506 for the Salt master open to the public.',
more_info: 'Active Salt vulnerabilities, CVE-2020-11651 and CVE-2020-11652 are exploiting Salt instances exposed to the internet. These ports should be closed immediately.',
link: 'https://www.alibabacloud.com/help/doc-detail/25471.htm',
Expand Down
2 changes: 1 addition & 1 deletion plugins/aws/codestar/codestarHasTags.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -109,4 +109,4 @@ describe('codestarHasTags', function () {
});
});
});
});
});
3 changes: 1 addition & 2 deletions plugins/aws/codestar/codestarValidRepoProviders.js
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ module.exports = {

let repoProvider = (describeProject.data.projectTemplateId.split('/').length > 1) ?
describeProject.data.projectTemplateId.split('/')[1] : '';

if (config.codestar_disallowed_repo_providers.includes(repoProvider)) {
helpers.addResult(results, 2,
`CodeStar project is using ${repoProvider} as repository provider which should not be used`,
Expand All @@ -78,4 +77,4 @@ module.exports = {
callback(null, results, source);
});
}
};
};
2 changes: 1 addition & 1 deletion plugins/aws/ec2/openSalt.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
title: 'Open Salt',
category: 'EC2',
domain: 'Compute',
severity: 'High',
severity: 'Critical',
description: 'Determine if TCP ports 4505 or 4506 for the Salt master are open to the public',
more_info: 'Active Salt vulnerabilities, CVE-2020-11651 and CVE-2020-11652 are exploiting Salt instances exposed to the internet. These ports should be closed immediately.',
link: 'https://help.saltstack.com/hc/en-us/articles/360043056331-New-SaltStack-Release-Critical-Vulnerability',
Expand Down
2 changes: 1 addition & 1 deletion plugins/azure/networksecuritygroups/openSalt.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
title: 'Open Salt',
category: 'Network Security Groups',
domain: 'Network Access Control',
severity: 'Medium',
severity: 'Critical',
description: 'Determine if TCP ports 4505 or 4506 for the Salt master are open to the public',
more_info: 'Active Salt vulnerabilities, CVE-2020-11651 and CVE-2020-11652 are exploiting Salt instances exposed to the internet. These ports should be closed immediately.',
link: 'https://help.saltstack.com/hc/en-us/articles/360043056331-New-SaltStack-Release-Critical-Vulnerability',
Expand Down
2 changes: 1 addition & 1 deletion plugins/google/vpcnetwork/openSalt.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
title: 'Open Salt',
category: 'VPC Network',
domain: 'Network Access Control',
severity: 'High',
severity: 'Critical',
description: 'Determine if TCP ports 4505 or 4506 for the Salt master are open to the public',
more_info: 'Active Salt vulnerabilities, CVE-2020-11651 and CVE-2020-11652 are exploiting Salt instances exposed to the internet. These ports should be closed immediately.',
link: 'https://help.saltstack.com/hc/en-us/articles/360043056331-New-SaltStack-Release-Critical-Vulnerability',
Expand Down
2 changes: 1 addition & 1 deletion plugins/oracle/networking/openSalt.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = {
title: 'Open Salt',
category: 'Networking',
domain: 'Network Access Control',
severity: 'Medium',
severity: 'Critical',
description: 'Determine if TCP ports 4505 or 4506 for the Salt master are open to the public',
more_info: 'Active Salt vulnerabilities, CVE-2020-11651 and CVE-2020-11652 are exploiting Salt instances exposed to the internet. These ports should be closed immediately.',
recommended_action: 'Restrict TCP ports 4505 and 4506 to known IP addresses',
Expand Down