fix: validate the topology as immutable (#8894)

(cherry picked from commit da8c324)
apecloud · Feb 7, 2025 · d0d97c6 · d0d97c6
1 parent f8de547
commit d0d97c6
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/apis/apps/v1/cluster_types.go b/apis/apps/v1/cluster_types.go
@@ -84,6 +84,7 @@ func init() {
 }
 
 // ClusterSpec defines the desired state of Cluster.
+// +kubebuilder:validation:XValidation:rule="!has(oldSelf.topology) || has(self.topology)", message="topology is required once set"
 type ClusterSpec struct {
 	// Specifies the name of the ClusterDefinition to use when creating a Cluster.
 	//
@@ -122,6 +123,7 @@ type ClusterSpec struct {
 	// It establishes the initial composition and structure of the Cluster and is intended for one-time configuration.
 	//
 	// +kubebuilder:validation:MaxLength=32
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="topology is immutable"
 	// +optional
 	Topology string `json:"topology,omitempty"`
 

diff --git a/config/crd/bases/apps.kubeblocks.io_clusters.yaml b/config/crd/bases/apps.kubeblocks.io_clusters.yaml
@@ -16059,9 +16059,15 @@ spec:
                   It establishes the initial composition and structure of the Cluster and is intended for one-time configuration.
                 maxLength: 32
                 type: string
+                x-kubernetes-validations:
+                - message: topology is immutable
+                  rule: self == oldSelf
             required:
             - terminationPolicy
             type: object
+            x-kubernetes-validations:
+            - message: topology is required once set
+              rule: '!has(oldSelf.topology) || has(self.topology)'
           status:
             description: ClusterStatus defines the observed state of the Cluster.
             properties:

diff --git a/deploy/helm/crds/apps.kubeblocks.io_clusters.yaml b/deploy/helm/crds/apps.kubeblocks.io_clusters.yaml
@@ -16059,9 +16059,15 @@ spec:
                   It establishes the initial composition and structure of the Cluster and is intended for one-time configuration.
                 maxLength: 32
                 type: string
+                x-kubernetes-validations:
+                - message: topology is immutable
+                  rule: self == oldSelf
             required:
             - terminationPolicy
             type: object
+            x-kubernetes-validations:
+            - message: topology is required once set
+              rule: '!has(oldSelf.topology) || has(self.topology)'
           status:
             description: ClusterStatus defines the observed state of the Cluster.
             properties: