update build #107
Merged
update build #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Feb 12, 2024
pjfanning
commented
- scala 2.13.12
- don't hardcode full scala versions in CI yml (easier maintenance)
- use more sbt-pekko-build style dependency management
mdedetrich
reviewed
Feb 12, 2024
| @@ -198,7 +198,7 @@ private[projection] class SlickProjectionImpl[Offset, Envelope, P <: JdbcProfile | |||
| databaseConfig.db.run(offsetStore.saveOffset(projectionId, offset)).map(_ => Done) | |||
|
|
|||
| private[projection] def newRunningInstance(): RunningProjection = | |||
| new SlickRunningProjection(RunningProjection.withBackoff(() => mappedSource(), settings), this) | |||
| new SlickRunningProjection(RunningProjection.withBackoff(() => this.mappedSource(), settings), this) | |||
There was a problem hiding this comment.
Whats reason behind this change, some deprecation warning?
There was a problem hiding this comment.
build issue after updating to scala 2.13.12
[error] /home/runner/work/incubator-pekko-projection/incubator-pekko-projection/slick/src/main/scala/org/apache/pekko/projection/slick/internal/SlickProjectionImpl.scala:201:70: reference to mappedSource is ambiguous;
[error] it is both defined in the enclosing class SlickProjectionImpl and inherited in the enclosing class SlickInternalProjectionState as method mappedSource (defined in class InternalProjectionState)
[error] In Scala 2, symbols inherited from a superclass shadow symbols defined in an outer scope.
[error] Such references are ambiguous in Scala 3. To continue using the inherited symbol, write `this.mappedSource`.
[error] Or use `-Wconf:msg=legacy-binding:s` to silence this warning. [quickfixable]
[error] new SlickRunningProjection(RunningProjection.withBackoff(() => mappedSource(), settings), this)
[error] ^
[error] one error found
[error] (slick / Compile / compileIncremental) Compilation failed
raboof
reviewed
Feb 12, 2024
| case Some(_) => Seq(Resolver.ApacheMavenSnapshotsRepo) | ||
| case None => Seq.empty | ||
| }) | ||
| resolvers += Resolver.ApacheMavenSnapshotsRepo |
There was a problem hiding this comment.
Maybe also update(/remove?) the comment above
There was a problem hiding this comment.
I've changed this with 59f2d1c
raboof
approved these changes
Feb 12, 2024
| @@ -15,6 +15,8 @@ sourceDistName := "apache-pekko-projection" | |||
| sourceDistIncubating := true | |||
|
|
|||
| ThisBuild / pekkoInlineEnabled := false | |||
| // we want to be able to test with snapshot versions of Pekko dependencies | |||
| ThisBuild / resolvers += Resolver.ApacheMavenSnapshotsRepo | |||
There was a problem hiding this comment.
it was nice that this used to be conditional, but not a big issue to have it here I suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.