ORC-1388: [C++] Support schema evolution from decimal to timestamp/string group #1761
Conversation
|
Thanks for fixing the CI. I will take a look this week. |
| public: | ||
| DecimalToStringVariantColumnReader(const Type& _readType, const Type& fileType, | ||
| StripeStreams& stripe, bool _throwOnOverflow) | ||
| : ConvertToStringVariantColumnReader(_readType, fileType, stripe, _throwOnOverflow), |
There was a problem hiding this comment.
Unrelated to this PR: we have many weird _xxx variable names appearing in the function signature. I'm thinking to do something like apache/arrow, which only use xxx_ as the name of private class member variables. In this way, we can get rid of the weird case like this.
There was a problem hiding this comment.
Unrelated to this PR: we have many weird
_xxxvariable names appearing in the function signature. I'm thinking to do something like apache/arrow, which only usexxx_as the name of private class member variables. In this way, we can get rid of the weird case like this.
Maybe we can use clang-tidy with option "readability-identifier-naming.ClassMemberSuffix" to do this. I can make a PR to fix the identifiers naming style this or next week.
What changes were proposed in this pull request?
Support conversion from
{decimal}
to
{string, char, varchar, timestamp, timestamp_instant}
Why are the changes needed?
Support schema evolution at cpp side.
How was this patch tested?
UT passed.
Was this patch authored or co-authored using generative AI tooling?
NO