[CXF-8997] AbstractSTSToken and TransportBinding Tests use TLSv1 on IBM #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to set https protocol to TLSv1 on IBM Java
reta
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractSTSTokenTest and TransportBindingTests no longer need to set https protocol to TLSv1 on IBM Java.
Current builds of CXF 4.0.x on IBM Java will fail the AbstractSTSTokenTest and TransportBindingTests due to their use of TLSv1. Note: IBM JDKs disable TLSv1 by default since around Java 8 (https://community.ibm.com/community/user/wasdevops/blogs/hiroko-takamiya1/2021/06/19/ibm-java-80630-disables-tlsv1-tlsv11-by-default-ho).
Removing the test case IBM control flag allows the default TLS to pass the tests.
Patch tested on:
CentOS Stream 9 on POWER with IBM Semeru 17, RedHat OpenJDK 17, and Eclipse Adoptium (Temurin) 17.
Windows 11 Pro on x64 Intel with IBM Semeru 17, and Azul Zulu 17.
MacOS 14.4.1 on AArch64 with IBM Semeru 17, and Amazon Corretto 17.