-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(catalog): capabilities properties #1185
Conversation
c12087a
to
d9f5df5
Compare
...camel-k-maven-plugin/src/main/java/org/apache/camel/k/tooling/maven/GenerateCatalogMojo.java
Show resolved
Hide resolved
properties.add(Property.from("serviceName", "quarkus.opentelemetry.tracer.resource-attributes")); | ||
properties.add(Property.from("sampler", "quarkus.opentelemetry.tracer.sampler")); | ||
properties.add(Property.from("samplerRatio", "quarkus.opentelemetry.tracer.sampler.ratio")); | ||
properties.add(Property.from("samplerParentBased", "quarkus.opentelemetry.tracer.sampler.parent-based")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice to validate if i.e. the same keys also apply to spring-boot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. I think this would be the next step when we onboard the new runtime. We'd need to understand how to harmonize the parameters expected by the operator according to the different runtimes requirements. The goal of this PR is to move towards that goal without breaking compatibility of what's expected now. Eventually it will be a matter of changing these parameters in the future catalog releases, driven by the changes in the operator as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there are many more questions that must be answered, i.e. :
- how to handle cases where a key is not applicable, but another one is needed
- how to handle breaking changes, so properties that have disappeared or become required ('d like to avoid having to do version checks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I acknowledge them but this PR doesn't aim to solve this aspect. This is something we need to address regardless this PR. Do you think that challenge can be tackled separately?
properties.add(Property.from("color", "quarkus.console.color")); | ||
properties.add(Property.from("format", "quarkus.log.console.format")); | ||
properties.add(Property.from("json", "quarkus.log.console.json")); | ||
properties.add(Property.from("jsonPrettyPrint", "quarkus.log.console.json.pretty-print")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a json logging option in spring-boot https://docs.spring.io/spring-boot/docs/3.0.0/reference/htmlsingle/#features.logging, it seems that to enable json logging one has to use a backend specific logging configuration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Same comment as with the above telemetry capability.
d9f5df5
to
238d514
Compare
@lburgazzoli I've addressed the |
Is it planned to backport to 3.2.x / 3.6.x for backward compatibility ? |
This idea in general is good as the description says, so +1. |
No. The compatibility will be managed at runtime, ie, 3.2 runtime mechanism will work in its own way, according to its spec. The operator will still have to handle (and deprecated as illustrated in https://github.com/apache/camel-k/pull/5251/files#diff-22dc2842d3dc75fd50c5856a16c240e8c17dc3f9785d8ab14dc6eb6a990134beR70) also the older approach which will eventually disappear after deprecation policy has expired. |
With this PR we enrich the catalog and let certain runtime aspects to be managed via properties (with something similar to this draft [1]). Together with a work on the operator, we'll be able to simplify the management of runtimes and offload the specific runtime aspects, being able to delegate this to the runtime directly. The result of this PR will enrich 3.8.0 future catalog as following:
Eventually any other runtime (ie Springboot) should be adding the specific capabilities accordingly and it would be transparent for the operator.
[1] apache/camel-k#5251
Release Note