Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert camel-quarkus-version removal from PR #1156 #1166

Merged

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Feb 5, 2024

Ref #1156

Revert to fix camel-k upstream issues with catalog in nightly builds.
Also camel-quarkus.version is referenced by camel-k code.

Release Note

NONE

@gansheer gansheer changed the title Revert camel-quarkus-version remove from PR #1156 Revert camel-quarkus-version removal from PR #1156 Feb 5, 2024
@claudio4j
Copy link
Contributor

yes, let's see if the revert works for the camel-k nightly builds. Maybe I overlooked it, but the maven property name camel-quarkus-version is different from the camel-quarkus.version defined in the yaml catalog (the second separator is dash), which still exits and is generated in GenerateCatalogMojo.

@squakez squakez merged commit 3938a34 into apache:main Feb 6, 2024
22 checks passed
@squakez
Copy link
Contributor

squakez commented Feb 7, 2024

The error we're getting is in the catalog generation due to:

[ERROR] Plugin org.apache.camel.k:camel-k-maven-plugin:3.6.0-SNAPSHOT or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.apache.camel.k:camel-k-maven-plugin:jar:3.6.0-SNAPSHOT (absent): Could not find artifact org.apache.camel.k:camel-k-maven-plugin:jar:3.6.0-SNAPSHOT -> [Help 1]: exit status 1

The problem is that maven expect the version parameter in

        <dependency>
            <groupId>org.apache.camel.quarkus</groupId>
            <artifactId>camel-quarkus-catalog</artifactId>
            <version>${camel-quarkus-version}</version>
        </dependency>
        <dependency>
            <groupId>org.apache.camel.quarkus</groupId>
            <artifactId>camel-quarkus-core</artifactId>
            <version>${camel-quarkus-version}</version>
        </dependency>

We need to understand why is that, and what kind of version we should put there in order to be aligned with the platform. Reverting completely #1156 should fix for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants