Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-39598: [C#] Fix verification script #39605

Merged
merged 2 commits into from
Jan 16, 2024
Merged

GH-39598: [C#] Fix verification script #39605

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4efa83d
Fix verification script
CurtHagenlocher Jan 15, 2024
a1c02fc
fix typo
CurtHagenlocher Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,8 +880,8 @@ test_csharp() {
if [ "${SOURCE_KIND}" = "local" ]; then
echo "Skipping sourelink verification on local build"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a minor typo:

Suggested change
echo "Skipping sourelink verification on local build"
echo "Skipping sourcelink verification on local build"

else
dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb
dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netcoreapp3.1/Apache.Arrow.pdb
dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netstandard2.0/Apache.Arrow.pdb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no experience with C# and I might be saying something that doesn't make sense but is there a reason why we don't test this when SOURCE_KIND is local?
We probably could find the issue on nightlies / maintenance branch if we also tested there instead of only when we have generated a Release candidate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the skip was added by #33799.

@westonpace Do you remember why you disabled the sourcelink check when SOURCE_KIND is local?

dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/net6.0/Apache.Arrow.pdb
fi

popd
Expand Down