GH-39001: [Java] Modularize remaining modules #39221
Conversation
|
|
|
dataset is having issues due to the directory holding native libs in JARs (the arch eg x86_64) is being treated as a package name. flight-core and other Flight modules requires additional command-line arguments. Netty is omitted due to requiring user-unfriendly command-line arguments. |
kou
changed the title
jduo
force-pushed
the
modularize-remaining
branch
from
9ba832c to
9701a21
Compare
jduo
requested review from
assignUser,
kou,
raulcd and
lidavidm
as code owners
|
Doc changes are required as different modules require more command line arguments. I'll update the docs. |
jduo
force-pushed
the
modularize-remaining
branch
3 times, most recently
from
ed7b6be to
c4c67b1
Compare
|
FYI for testing runing the java-jars job might be useful. You can start it by commenting |
jduo
force-pushed
the
modularize-remaining
branch
from
c4c67b1 to
ad83e89
Compare
jduo
force-pushed
the
modularize-remaining
branch
3 times, most recently
from
72747ae to
b4d9662
Compare
Thanks, I'll run that now. |
|
@GitHub-Action crossbow submit java-jars |
|
@github-actions crossbow submit java-jars |
|
Revision: 35f7cba Submitted crossbow builds: ursacomputing/crossbow @ actions-e879fe00cc
|
|
@github-actions crossbow submit java-jars |
Module is combined with flight-core now.
Use ARROW_JNI_JAVA_<library>_[BIN|LIB]DIR instead of overriding CMAKE_INSTALL_[BIN|LIB]DIR
jduo
force-pushed
the
modularize-remaining
branch
from
02c0b82 to
3607ed8
Compare
github-actions
bot
added
awaiting change review
Remove explicit setting of ARROW_JAVA_JNI_ARCH_DIR in build system. Clarify that this should get auto-detected.
|
@github-actions crossbow submit java-jars |
|
Revision: c5723d1 Submitted crossbow builds: ursacomputing/crossbow @ actions-8e395163f9
|
|
@github-actions crossbow submit java-jars |
|
Revision: 0ece855 Submitted crossbow builds: ursacomputing/crossbow @ actions-0785af577e
|
|
@kou , I've switched to using CMAKE_SYSTEM_PROCESSOR and changed CI scripts and POM files to let auto-detection figure ARROW_JAVA_JNI_ARCH_DIR. I think this addresses everything. |
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 92682f0. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
### Rationale for this change Modularize remaining modules outside of memory modules, vector, and format. ### What changes are included in this PR? ### Are these changes tested? Yes, existing unit tests now run with modules when using JDK9+. ### Are there any user-facing changes? Yes. There are new command-line options that may be necessary. The way of specifying the output directory for JNI native library builds differs. The flight-grpc module has been eliminated since it is now built into flight-core. Documentation has been updated for these changes. **This PR includes breaking changes to public APIs.** There are a number of package structure changes and some modules now need additional command-line arguments. * Closes: apache#39001 Authored-by: James Duong <james.duong@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
### Rationale for this change Modularize remaining modules outside of memory modules, vector, and format. ### What changes are included in this PR? ### Are these changes tested? Yes, existing unit tests now run with modules when using JDK9+. ### Are there any user-facing changes? Yes. There are new command-line options that may be necessary. The way of specifying the output directory for JNI native library builds differs. The flight-grpc module has been eliminated since it is now built into flight-core. Documentation has been updated for these changes. **This PR includes breaking changes to public APIs.** There are a number of package structure changes and some modules now need additional command-line arguments. * Closes: apache#39001 Authored-by: James Duong <james.duong@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
### Rationale for this change Modularize remaining modules outside of memory modules, vector, and format. ### What changes are included in this PR? ### Are these changes tested? Yes, existing unit tests now run with modules when using JDK9+. ### Are there any user-facing changes? Yes. There are new command-line options that may be necessary. The way of specifying the output directory for JNI native library builds differs. The flight-grpc module has been eliminated since it is now built into flight-core. Documentation has been updated for these changes. **This PR includes breaking changes to public APIs.** There are a number of package structure changes and some modules now need additional command-line arguments. * Closes: apache#39001 Authored-by: James Duong <james.duong@improving.com> Signed-off-by: David Li <li.davidm96@gmail.com>
|
@github-actions crossbow submit verify-rc-source-integration-linux-* |
|
I am verifying if this caused: #41201 |
|
Revision: 0ece855 Submitted crossbow builds: ursacomputing/crossbow @ actions-c29cc1b749
|
Rationale for this change
Modularize remaining modules outside of memory modules, vector, and format.
What changes are included in this PR?
Are these changes tested?
Yes, existing unit tests now run with modules when using JDK9+.
Are there any user-facing changes?
Yes. There are new command-line options that may be necessary. The way of specifying the output directory for
JNI native library builds differs. The flight-grpc module has been eliminated since it is now built into flight-core.
Documentation has been updated for these changes.
This PR includes breaking changes to public APIs.
There are a number of package structure changes and some modules now need additional command-line arguments.