Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add peer created callback #52

Merged
merged 18 commits into from
Mar 13, 2024
Merged

Add peer created callback #52

merged 18 commits into from
Mar 13, 2024

Conversation

USAMAWIZARD
Copy link
Contributor

@USAMAWIZARD USAMAWIZARD commented Dec 17, 2023

@USAMAWIZARD
Copy link
Contributor Author

This callback can be used to give more control to user for example if the user want to change somethings with the peerConnection object before the publishing has been started

Copy link

codecov bot commented Dec 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cb75c5f) 14.13% compared to head (c772d00) 14.22%.

Files Patch % Lines
...edia/webrtcandroidframework/core/WebRTCClient.java 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     14.13%   14.22%   +0.08%     
- Complexity      333      336       +3     
============================================
  Files           155      155              
  Lines         10340    10339       -1     
  Branches       1138     1134       -4     
============================================
+ Hits           1462     1471       +9     
+ Misses         8711     8698      -13     
- Partials        167      170       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	webrtc-android-framework/src/test/java/io/antmedia/webrtcandroidframework/WebRTCClientTest.java
#	webrtc-android-framework/src/test/java/io/antmedia/webrtcandroidframework/api/DefaultConferenceWebRTCListenerTest.java
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 15.70%. Comparing base (5163060) to head (93f033d).

Files Patch % Lines
...edia/webrtcandroidframework/core/WebRTCClient.java 77.77% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #52      +/-   ##
============================================
+ Coverage     15.62%   15.70%   +0.08%     
- Complexity      438      442       +4     
============================================
  Files           156      156              
  Lines         10537    10536       -1     
  Branches       1141     1137       -4     
============================================
+ Hits           1646     1655       +9     
+ Misses         8726     8713      -13     
- Partials        165      168       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@burak-58 burak-58 merged commit 5d8ffed into master Mar 13, 2024
2 checks passed
@burak-58 burak-58 deleted the addPeerCreatedCallback branch March 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

recorded mp4 files are not playing on Mac & IOS Safari.
3 participants