Fail early if postgres_configuration_secret is specified by does not exist #2015
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
force-pushed
the
better-error-handling-pg-secret
branch
from
625ecd2 to
a66ef26
Compare
aknochow
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Current, the operator checks if the secret exists, sees that it does not, then generates a secret and sets that on on the status.
So you end up with the generated secret on the status, but still have an invalid postgres_configuration_secret on the AWX spec.
That could cause some serious issues for backup and restores...
This PR fails early if the specified secret does not exist and leaves an error on the AWX CR for the user to find, and fix.
ISSUE TYPE