[PR #9672/7a6125b9 backport][stable-10] test helper: improvements #9673
+138
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 7a6125b)
ansibullbot
added
backport
new_contributor
felixfontein
deleted the
patchback/backports/stable-10/7a6125b99a000dbbd572514bc796da6bb3973af9/pr-9672
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #9672 as merged into main (7a6125b).
changes:
from_module(),from_file()andfrom_spec()now all have a similar order of parametersfrom_module()tries extensions.yamland.ymlbefore giving uptest_specfromfrom_module()from_file()now receives an open, readable, file handle instead of a filenameHelperno longer accepts a test specification that is a top-level list of testcases, it must be a dict containing the keytest_cases, which will be the list.from_spec()SUMMARY
ISSUE TYPE
COMPONENT NAME
tests/unit/plugins/modules/helper.py
tests/unit/plugins/modules/test_snap.py