Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keycloak authorization resources #8165

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Implement keycloak authorization resources #8165

wants to merge 14 commits into from
+598 −0

Conversation

maximilianpohle
Copy link

SUMMARY

Adding keycloak_authz_resource module.

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

keycloak_authz_resource

ADDITIONAL INFORMATION

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot
Copy link
Collaborator

cc @eikef @mattock @ndclt
click here for bot help

@ansibullbot ansibullbot added identity module module module_utils module_utils needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) labels Mar 29, 2024
@maximilianpohle maximilianpohle force-pushed the main branch 3 times, most recently from de66447 to c158118 Compare March 29, 2024 10:01
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Mar 29, 2024
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed ci_verified Push fixes to PR branch to re-run CI needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 29, 2024
@maximilianpohle maximilianpohle marked this pull request as draft March 29, 2024 17:30
@ansibullbot ansibullbot added the WIP Work in progress label Mar 29, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-8 Automatically create a backport for the stable-8 branch labels Mar 29, 2024
@felixfontein
Copy link
Collaborator

Thanks for your contribution! In case you didn't do that yet, please check out the section in CONTRIBUTING.md on creating new modules (https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md#creating-new-modules-or-plugins) :)

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Apr 6, 2024
@felixfontein felixfontein removed the backport-8 Automatically create a backport for the stable-8 branch label Apr 23, 2024
@felixfontein
Copy link
Collaborator

Ping @maximilianpohle

@maximilianpohle
Copy link
Author

@felixfontein still on it, please give me some time.

Need to check the contribution notes still.

@ansibullbot ansibullbot added the tests tests label Jun 1, 2024
maximilianpohle and others added 2 commits June 2, 2024 19:11
@maximilianpohle @felixfontein
Update plugins/modules/keycloak_authz_resource.py
f3bb1da 
Co-authored-by: Felix Fontein <felix@fontein.de>
@maximilianpohle @felixfontein
Update plugins/modules/keycloak_authz_resource.py
123714c 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jun 13, 2024
@ansibullbot
Copy link
Collaborator

cc @thomasbach-dev
click here for bot help

armkeh
armkeh suggested changes Sep 7, 2024
View reviewed changes
Copy link
Contributor

@armkeh armkeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I found a few places which refer to permissions, scopes or groups instead of resources.

plugins/module_utils/identity/keycloak/keycloak.py Outdated Show resolved Hide resolved
plugins/module_utils/identity/keycloak/keycloak.py Outdated Show resolved Hide resolved
plugins/modules/keycloak_authz_resource.py Outdated Show resolved Hide resolved
plugins/modules/keycloak_authz_resource.py Outdated Show resolved Hide resolved
plugins/modules/keycloak_authz_resource.py Outdated Show resolved Hide resolved
plugins/modules/keycloak_authz_resource.py Outdated Show resolved Hide resolved
tests/integration/targets/keycloak_authz_resource/readme.adoc Outdated Show resolved Hide resolved
maximilianpohle and others added 7 commits September 13, 2024 13:43
@maximilianpohle @armkeh
Update plugins/module_utils/identity/keycloak/keycloak.py
aa9dde2 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update plugins/modules/keycloak_authz_resource.py
8943796 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update tests/integration/targets/keycloak_authz_resource/readme.adoc
25f485a 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update plugins/modules/keycloak_authz_resource.py
3b6d35e 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update plugins/modules/keycloak_authz_resource.py
d026a6c 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update plugins/modules/keycloak_authz_resource.py
45154fa 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@maximilianpohle @armkeh
Update plugins/module_utils/identity/keycloak/keycloak.py
836dc79 
Co-authored-by: Mark Armstrong <markparmstrong@gmail.com>
@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Sep 13, 2024
@felixfontein felixfontein added the backport-9 Automatically create a backport for the stable-9 branch label Sep 17, 2024
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Sep 25, 2024
@felixfontein felixfontein removed the backport-9 Automatically create a backport for the stable-9 branch label Oct 7, 2024
@ansibullbot
Copy link
Collaborator

@maximilianpohle this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot added merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed stale_ci CI is older than 7 days, rerun before merging labels Jan 13, 2025
@ansibullbot
Copy link
Collaborator

The test action-group failed with 2 errors:

meta/runtime.yml:0:0: module 'keycloak_authz_resource' is not part of 'keycloak' action group
plugins/modules/keycloak_authz_resource.py:0:0: module does not document itself as part of action group 'keycloak', but it should; you need to add community.general.keycloak.actiongroup_keycloak to "extends_documentation_fragment" in DOCUMENTATION

click here for bot help

@ansibullbot ansibullbot added the ci_verified Push fixes to PR branch to re-run CI label Jan 13, 2025
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Jan 21, 2025
@ansibullbot
Copy link
Collaborator

@maximilianpohle this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI stale_ci CI is older than 7 days, rerun before merging labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@armkeh armkeh armkeh requested changes

Assignees
No one assigned
Labels
check-before-release PR will be looked at again shortly before release and merged if possible. identity integration tests/integration merge_commit This PR contains at least one merge commit. Please resolve! module_utils module_utils module module needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html new_contributor Help guide this first time contributor plugins plugin (any type) tests tests WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maximilianpohle @ansibullbot @felixfontein @armkeh