Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Storage to save tabs #25

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

LucasPadovan
Copy link

Hello!
This is a fork I've been using for a couple of months. It has some fixes to use local storage to save the tabs.
A couple of things to have in mind:

  • Multiple panes are partially supported (when reopened, they are put all on the same pane)
  • I wasn't intended to be released on public, so I have to change things back to their original (like the one on package.json, I was getting an error on an updater plugin)
  • Add comments to allow more understanding on the code.

If you are interested, we can talk about everything here.
If not, and you are reading and needing this plugin, feel free to use it from my repo.

Thanks!

@anderoonies
Copy link
Owner

hey lucas!
thanks for the pull request.
there are still unavoidable issues with how panes are handled that mean it's impossible to preserve the state of panes across sessions, which i see you've already noticed.
that obstacle was enough to deter me until it's fixed—there seems to be some activity in changing how tabs are serialized with the addition of modified text buffer layers.
if you'd like to update the package.json i'd be happy to pull this into the repo. i still have my eyes peeled for when atom's behavior changes to make git-tabs work how it should, but for now i haven't been maintaining things.

@LucasPadovan
Copy link
Author

Hello again, I've made a couple of fixes and removed the changes that where not needed.

Feel free to try, comment or merge this PR.

Also I've tried (without any luck) to copy the way Atom handles the workspace on opening/closing.
I'll keep trying to see if there is a way to emulate it for branch changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants