-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger update #128
Logger update #128
Conversation
library/drivers/common/scoreboard.sv
Outdated
@@ -137,7 +139,7 @@ package scoreboard_pkg; | |||
this.source_byte_stream.push_front(source_byte); | |||
end | |||
this.source_byte_stream_size += this.source_monitor.mailbox.num(); | |||
`INFOV(("Source transaction received, size: %d - %d", this.source_monitor.mailbox.num(), this.source_byte_stream_size), 200); | |||
this.info($sformatf("Source transaction received, size: %d - %d", this.source_monitor.mailbox.num(), this.source_byte_stream_size), ADI_VERBOSITY_DEBUG); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for other reviewers: the reason for having to have $sformatf is that it is not possible to pass an arbitrary a varying number of keyword in systemverilog.
Normally we use macros to emulate the "**kargs" behavior, but the scope for the verbosity level is problematic.
- Added a reporter and a component base classes to instantiate from - Feature to get path from which hierarchy was reporting called - Added separate logging options for elaborated code Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
- Updated class inheritance to support hierarchy level logging - Updated libraries to use the appropriate reporting functions Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
- Categorized verbosity levels - Updated projects and libraries - Set the default verbosity level none for test_programs Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
6de3537
to
d304209
Compare
Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
Updated and rebased the logger on main. Fixed compatibility issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update, the errors print in the following format:
Error: [ERROR] @ 1425 ns: [SPI Engine Environment.AXI Manager sequencer] Address : 0000000044a00000; Data mismatch. Read data is : 00010301; expected is 00010300
The double error/fatal/info may be redundant, but that's is a nitpick
- Fixed dma_trans - Removed excess text from logging on Warnings, Errors and Fatal messages Signed-off-by: Istvan-Zsolt Szekely <istvan.szekely@analog.com>
When implementing and updating the modules, I haven't checked how are the messages actually printed, I was focusing on function over form. Updated the 3 non-Info messages. |
Update logger functions: