Rgetz misc fixes - add libzstd to README_BUILD.md and don't allow WITH_IIOD_USBD=0 when WITH_AIO=1 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ./README_BUILD.md we keep track of Prerequisites, now for libiio 1.x should resolve analogdevicesinc#1045 Signed-off-by: Robin Getz <rgetz@mathworks.com>
at cmake time, not at link time. Turns this: /usr/bin/ld: CMakeFiles/iiod.dir/iiod.c.o: in function `main': /home/benja/git/libiio/iiod/iiod.c:531: undefined reference to `start_usb_daemon' [100%] Built target iio_stresstest collect2: error: ld returned 1 exit status make[2]: *** [iiod/CMakeFiles/iiod.dir/build.make:227: iiod/iiod] Error 1 make[1]: *** [CMakeFiles/Makefile2:466: iiod/CMakeFiles/iiod.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [100%] Built target iio_attr make: *** [Makefile:136: all] Error 2 into this: CMake Error at iiod/CMakeLists.txt:72 (message): Sorry, USB support in iiod (WITH_IIOD_USBD) requires async I/O support (WITH_AIO) should resolve analogdevicesinc#984 Signed-off-by: Robin Getz <rgetz@mathworks.com>
rgetz
changed the title
pcercuei
approved these changes
Dec 7, 2023
|
Technically libzstd is not a requirement. But I guess it makes sense to add it to the list of build dependencies since it's expected to be enabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #984 and #1045