Implemented profile generation for adrv9002 plugin #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei47w
requested review from
mhennerich,
dNechita,
nunojsa and
cristina-suteu
andrei47w
force-pushed
the
navassa-profile-gen
branch
from
7115b03 to
54e130e
Compare
andrei47w
force-pushed
the
navassa-profile-gen
branch
2 times, most recently
from
aa83a95 to
ce10c60
Compare
andrei47w
force-pushed
the
navassa-profile-gen
branch
from
9b0c012 to
51cdb14
Compare
|
Has anyone besides Andrei, tested this? |
cristina-suteu
approved these changes
Nov 29, 2023
dNechita
reviewed
Nov 29, 2023
dNechita
reviewed
Nov 29, 2023
nunojsa
reviewed
Nov 30, 2023
There was a problem hiding this comment.
Ok, here it goes my first review. One thing that worries me and I would like to see fixed: Please follow the coding style used in the plugin. Consistency matters and having two completely different styles makes it harder to read the code.
On another note, just squash all the commits into one adding the profile gen. Commits like minor fixes does not make any sense in something that we are just adding support for.
mhennerich
approved these changes
Dec 4, 2023
- similar UI to Transceiver Evaluation Software (TES) - can save profile and stream image to files or write them to device - 2 presets available for default profile values: live device (read from device) and LTE - error messages are displayed in Debug info section (profile generation errors are also displayed) - requires navassa-profile-gen-cli to work - included cJSON for generating the adrv9002 structure config Signed-off-by: Andrei Popa <andrei.popa@analog.com>
andrei47w
force-pushed
the
navassa-profile-gen
branch
from
51cdb14 to
2c4cacc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar UI to Transceiver Evaluation Software (TES)
can save profile and stream image to files or write them to device
2 presets available for default profile values: live device (read from device) and LTE
error messages are displayed in Debug info section (profile generation errors are also displayed)
requires adrv9001-iio-cli to work
included cJSON for generating the adrv9002 structure config