AD400x: fix sign for even-numbered devices #51
+1,350
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threexc
requested review from
D-Disha,
SaikiranGudla and
jansunil
as code owners
threexc
changed the title
threexc
force-pushed
the
tgamblin/ad400x_sign
branch
2 times, most recently
from
bb133b5 to
c86aac5
Compare
The channel name property in Base.m has to be removed, since it varies between differential and pseudo-differential devices. The SampleRate functionality has been simplified and moved into each individual class, as attempts to make it work with varying channel names as a per-channel property while the value and getter/setter methods themselves were defined in AD400x/Base.m didn't seem to work. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Run gen_sysobj_doc.m and commit the changes. Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
threexc
force-pushed
the
tgamblin/ad400x_sign
branch
from
c86aac5 to
0bb41e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AD400x: fix sign for even-numbered devices
The channel name property in Base.m has to be removed, since it varies
between differential and pseudo-differential devices.
Also change where the SampleRate property and the setters are defined - now there's a version in each device class.
PR Type
PR Checklist