adi:ad559xr:Added Matlab Support #47
Conversation
D-Disha
requested review from
ribdp,
SaikiranGudla and
jansunil
as code owners
| end | ||
|
|
||
| end | ||
|
|
There was a problem hiding this comment.
Are we not adding any attributes here in the driver?
There was a problem hiding this comment.
No this is only targeted at data capture
There was a problem hiding this comment.
We can still add s-rate attribute perhaps? (if it's already part of Linux driver)
|
|
||
| % Instantiate the system object | ||
| rx = adi.AD5592r.Rx(); | ||
| rx.uri = 'serial:COM43,230400,8n1n'; |
There was a problem hiding this comment.
Does this part have a linux driver? if yes, should we add the URI as 'ip:analog.local'?
There was a problem hiding this comment.
Yes this part does have a linux driver but matlab is not a requested feature by apps and only the IIO fw ADC features are supported after an internal discussion. I this case, I feel it is okay to target the serail com port as uri
There was a problem hiding this comment.
But isn't it a generic standard that we provide the IP in all the drivers, even though we don't test it? @SaikiranGudla do you remember why we started adding the IP?
There was a problem hiding this comment.
True... In case the Linux drivr exists, we put it to network address (ip here)... only if there's no Linux driver, we can go with serial uris.
D-Disha
force-pushed
the
ad559xr
branch
2 times, most recently
from
35de8f6 to
ca7a125
Compare
Added Rx.m for ad5592r and ad5593r Added example script for data capture Signed-off-by: Disha D <Disha.D@analog.com>
Added Rx.m for ad5592r and ad5593r
Added example script for data capture
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist