Design System Reskin #1173
Design System Reskin #1173
Conversation
KludgeKML
force-pushed
the
rework-councils-list
branch
3 times, most recently
from
112fc5c to
b14d328
Compare
KludgeKML
force-pushed
the
rework-councils-list
branch
16 times, most recently
from
4c1f5a1 to
40a7225
Compare
KludgeKML
requested review from
matthillco,
1pretz1,
jon-kirwan and
kashifatcha
KludgeKML
force-pushed
the
rework-councils-list
branch
from
40a7225 to
8a0cd98
Compare
KludgeKML
force-pushed
the
rework-councils-list
branch
from
d3106c6 to
2b9b07e
Compare
KludgeKML
force-pushed
the
rework-councils-list
branch
from
7d5893a to
c294e9f
Compare
|
KludgeKML
force-pushed
the
rework-councils-list
branch
3 times, most recently
from
38a9dc1 to
ad076f5
Compare
There was a problem hiding this comment.
Thanks for making those changes Keith! Table presenter is a good addition and the new summary list looks great! Approving as nothing major to block anymore, I do have a few suggestions below which can either be rolled into another PR (as this one is a bit large).
I had one more minor point on the interaction table column, I think it looks a bit strange as the font / line height is smaller and greyed. Making the font size consistent would be good and possibly the colour (as it is v similar to the black full size).
It's been removed, so there's a temporary loss of functionality on those two lists, but there's a larger question about filtering that I'm planning to address when this is merged. If we think the temporary loss is too annoying, we could add in a simple link to toggle broken/all?
Playing about with the UI, I'd probably say not being able to filter by broken links is a bit annoying. A toggle sounds a good idea in the meantime, or if the filtering work is on the way soon then I think it's probably okay as is for now.
It's slightly more awkward to sort by traffic on the other two lists, so I thought it would be reasonable to leave the sort order as it currently is. I'm experimenting with giving the tables sortable headers.
I think ordering by views is definitely the most useful sort option but not a blocker if not poss + sortable table headers sounds good!
- Update base layout - Update JS and CSS with required components, remove obsolete JS/CSS - Add application.css to manifest - This is a publishing app, so use their more generous page width
- Add shared general-purpose links table partial - Add style for the edit links page - Add colour tags for link status - Update url presenter for use in the shared table - Change link status alerts to use Warning Text - Remove obsolete shared file - Add visually hidden info to edit link in links table Fix caps on "showing top" (SQUASH INTO LINKS)
KludgeKML
force-pushed
the
rework-councils-list
branch
3 times, most recently
from
9d33bf0 to
dee9a70
Compare
- Remove obsolete shared local authorities partial - split Homepage URL edit field into separate view/route - Add sidebar styles for council pages - Add metadata presenter code to LA presenter - Add active scope to local_authority model - Accept retired tag in index, default to only showing enabled
- Add govuk page title/link to services index
- Remove unnecessary JS - Update Routes for new forms. - Add component styles required - Add design system styles - Update controller to pass new parameters directly to exporter, and exporter to handle that. - Remove public_send in exporter now that we're calling it with (sanitised) params.
- Remove LGSL code expectation - Remove links expectation - Update broken link counter position/display - Remove nav tabs expectation (put this somewhere more general) - rename councils to avoid heisenbug where bbb appears first because it's in the assets digest filename.
- as per Whitehall, if run in dev environment, autocorrect by default - Add ERB linting step in CI
KludgeKML
force-pushed
the
rework-councils-list
branch
from
dee9a70 to
1806ade
Compare
Experimental visual refresh which updates Local Links Manager to use govuk_publishing_components elements and Design System styles and components instead of the old Bootstrap-based ones.
https://trello.com/c/JYROECMz/1592-reskin-local-links-manager
Screenshots:
Before:
After:
Before:
After: