[WIP] Move detailed guide document #4610
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sairamya93
force-pushed
the
move-detailed-guide-document
branch
2 times, most recently
from
8747e78 to
12ba923
Compare
- Copied the View from government-frontend - Commit audit trail: https://github.com/alphagov/government-frontend/blob/1503b2907f39e2f11881d5a6c66644792022d549/app/views/content_items/detailed_guide.html.erb
- Added the title - Updated the metadata in the header to fetch from govuk_publishing_components directly - Added the description tag in the header
Commit audit trail: - https://github.com/alphagov/government-frontend/blob/842a887dc0c83311a9ead2daa08bd430ad0ac347/app/helpers/content_items_helper.rb > app/helpers/govuk_personalisation_helper.rb - https://github.com/alphagov/government-frontend/blob/842a887dc0c83311a9ead2daa08bd430ad0ac347/app/controllers/content_items_controller.rb#L4 > app/controllers/content_items_controller.rb
- Updated the code to retrieve 'title' value directly instead of the method 'title_and_context' - Replaced title with heading component
Audit trail: https://github.com/alphagov/government-frontend/blob/596c574714bd821046c77a332c807c9c0d47334b/app/presenters/content_item/political.rb Added tests for political concern
Back-to-top component is rendered as part of contents-list-with-body component The files are copied from government-frontend Audit trail: https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/views/components/_back_to_top.html.erb https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/assets/stylesheets/components/_back-to-top.scss https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/views/components/docs/back_to_top.yml Audit trail for tests: https://github.com/alphagov/government-frontend/blob/a718ddf50ab81320b3586bfb31acf0a9ea7ef82e/test/components/back_to_top_test.rb Add tests for back to top component Audit trail: https://github.com/alphagov/government-frontend/blob/a718ddf50ab81320b3586bfb31acf0a9ea7ef82e/test/components/back_to_top_test.rb
Contents-list-with-body component is applicable for other document types such as corporate_information_page,document_collection,specialist document Audit trail: https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/views/components/_contents_list_with_body.html.erb https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/assets/stylesheets/components/_contents-list-with-body.scss https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/views/components/docs/contents_list_with_body.yml Audit trail for tests: https://github.com/alphagov/government-frontend/blob/a718ddf50ab81320b3586bfb31acf0a9ea7ef82e/test/components/contents_list_with_body_test.rb
…sheet The files are copied over from government-frontend Audit trail: https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/views/shared/_published_dates_with_notification_button.html.erb https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/assets/stylesheets/views/_published-dates-button-group.scss
Copied over the module Contents List and added as a concern in frontend Updated to use the code to strip trailing colons in headings in the method : extract_headings_with_ids Audit trail: https://github.com/alphagov/government-frontend/blob/85ede5293306d70f701749822a2ad0c75f201c5a/app/presenters/content_item/contents_list.rb
sairamya93
force-pushed
the
move-detailed-guide-document
branch
from
12ba923 to
646fde5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
To handle the rendering of detailed_guide document type from government_frontend to frontend as part of [RFC 175]
Why
https://trello.com/c/X9bILs3t/444-move-document-type-detailedguide-from-government-frontend-to-frontend
How
Screenshots?