Skip to content

Commit

Permalink
Fix incorrect destination address when hostname_variable equals with …
Browse files Browse the repository at this point in the history
…destination_address
  • Loading branch information
xiaozhu36 committed Jul 10, 2019
1 parent 675c278 commit 2b8a457
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ IMPROVEMENTS:

BUG FIXES:

- Fix grouping dynamic inventory on security group bug ([#165](https://github.com/alibaba/ansible-provider/pull/165))
- Fix incorrect destination address when hostname_variable equals with destination_address ([#170](https://github.com/alibaba/ansible-provider/pull/170))
- Fix grouping dynamic inventory on security group bug ([#169](https://github.com/alibaba/ansible-provider/pull/169))
- Default to describe all instances in all regions ([#158](https://github.com/alibaba/ansible-provider/pull/158))
- Fix ecs_instance_filters last page describe bug ([#157](https://github.com/alibaba/ansible-provider/pull/157))
- Fix ecs_instance_filters's page_size bug ([#156](https://github.com/alibaba/ansible-provider/pull/156))
Expand Down
4 changes: 2 additions & 2 deletions contrib/inventory/alicloud.py
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,8 @@ def add_instance(self, instance, region):
# If we can't get a nice hostname, use the destination address
if not hostname:
hostname = dest

hostname = self.to_safe(hostname).lower()
else:
hostname = self.to_safe(hostname).lower()

# if we only want to include hosts that match a pattern, skip those that don't
if self.pattern_include and not self.pattern_include.match(hostname):
Expand Down

0 comments on commit 2b8a457

Please sign in to comment.