chore: upgrade golangci-lint v1.56.1

Signed-off-by: Alex Szakaly <alex.szakaly@gmail.com>
alex1989hu · Feb 10, 2024 · 50e31ba · 50e31ba
1 parent 4718d3c
commit 50e31ba
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -23,4 +23,4 @@ jobs:
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v4
       with:
-        version: v1.55.2
+        version: v1.56.1
diff --git a/cmd/serve.go b/cmd/serve.go
@@ -48,7 +48,7 @@ var (
 		Use:   "serve",
 		Short: "Starts operator for Kubelet Serving Certificate Approver",
 		Long:  "",
-		Run: func(cmd *cobra.Command, args []string) {
+		Run: func(_ *cobra.Command, _ []string) {
 			startServer()
 		},
 	}

diff --git a/controller/certificatesigningrequest/controller_test.go b/controller/certificatesigningrequest/controller_test.go
@@ -386,7 +386,7 @@ func TestReconcileValidCSR(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			sar := &authorizationv1.SubjectAccessReview{
 				Status: authorizationv1.SubjectAccessReviewStatus{
 					Allowed: true,
@@ -441,7 +441,7 @@ func TestReconcileParseCSRError(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			sar := &authorizationv1.SubjectAccessReview{
 				Status: authorizationv1.SubjectAccessReviewStatus{
 					Allowed: true,
@@ -498,7 +498,7 @@ func TestReconcileRecognizeError(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			return true, &authorizationv1.SubjectAccessReview{}, nil
 		})
 
@@ -548,7 +548,7 @@ func TestReconcileAuthorizationError(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			return true, &authorizationv1.SubjectAccessReview{}, errAuthorization
 		})
 
@@ -598,7 +598,7 @@ func TestReconcileAuthorizationDenied(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			sar := &authorizationv1.SubjectAccessReview{
 				Status: authorizationv1.SubjectAccessReviewStatus{
 					Allowed: false,
@@ -656,7 +656,7 @@ func TestReconcileUpdateApprovalError(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"create",
 		"subjectaccessreviews",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			sar := &authorizationv1.SubjectAccessReview{
 				Status: authorizationv1.SubjectAccessReviewStatus{
 					Allowed: true,
@@ -670,7 +670,7 @@ func TestReconcileUpdateApprovalError(t *testing.T) {
 	fakeClientset.Fake.PrependReactor(
 		"update",
 		"certificatesigningrequests",
-		func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
+		func(_ clientgotesting.Action) (handled bool, ret runtime.Object, err error) {
 			return true, &certificatesv1.CertificateSigningRequest{}, errApprovalUpdate
 		})
 

diff --git a/e2e/scenario_test.go b/e2e/scenario_test.go
@@ -71,7 +71,7 @@ type ApproverInstance struct {
 func InitializeScenario(s *godog.ScenarioContext) {
 	var instance ApproverInstance
 
-	s.Before(func(ctx context.Context, sc *godog.Scenario) (context.Context, error) {
+	s.Before(func(ctx context.Context, _ *godog.Scenario) (context.Context, error) {
 		clientset, restConfig, err := createNewClientSet()
 		if err != nil {
 			return ctx, err