Merge pull request #13 from aks-lts/haitao/hide_more_variables

hide some of the variables in githubAction
aks-lts · Apr 18, 2024 · ec2837f · ec2837f
2 parents c9d3199 + 12fb66e
commit ec2837f
Show file tree

Hide file tree

Showing 4 changed files with 502 additions and 492 deletions.
diff --git a/.github/workflows/deploy-lts-prow.yaml b/.github/workflows/deploy-lts-prow.yaml
@@ -20,7 +20,10 @@ jobs:
       KUBEKINS_E2E_TAG: v20230703-e6ae5b372a-master
     steps:
       - name: Generate fake mount secret
-        run: echo FAKE_MOUNT_SECRET=$(echo '{"account":"fake","password":"fake"}' | base64) >> "$GITHUB_ENV"
+        run: |
+          FAKE_MOUNT_SECRET=$(echo '{"account":"fake","password":"fake"}' | base64)
+          echo "::add-mask::$FAKE_MOUNT_SECRET"
+          echo "FAKE_MOUNT_SECRET=$FAKE_MOUNT_SECRET" >> "$GITHUB_ENV"
 
       - name: Check out repo
         uses: actions/checkout@v3
@@ -44,16 +47,22 @@ jobs:
       - name: Fetch config
         run: |
           echo "PROW_HOST=${{ steps.bicep.outputs.prowHostName }}" >> "$GITHUB_ENV"
-          echo "AZURE_STORAGE_ACCOUNT_USER=${{ steps.bicep.outputs.storageAccountName }}" >> "$GITHUB_ENV"
-          echo "PUBLIC_IP_NAME=${{ steps.bicep.outputs.publicIpName }}" >> "$GITHUB_ENV"
-          echo "PUBLIC_IP_ADDRESS=${{ steps.bicep.outputs.publicIpAddress }}" >> "$GITHUB_ENV"
+          AZURE_STORAGE_ACCOUNT_USER=${{ steps.bicep.outputs.storageAccountName }}
+          echo "::add-mask::$AZURE_STORAGE_ACCOUNT_USER"
+          echo "AZURE_STORAGE_ACCOUNT_USER=$AZURE_STORAGE_ACCOUNT_USER" >> "$GITHUB_ENV"
+          PUBLIC_IP_NAME=${{ steps.bicep.outputs.publicIpName }}
+          echo "::add-mask::$PUBLIC_IP_NAME"
+          echo "PUBLIC_IP_NAME=$PUBLIC_IP_NAME" >> "$GITHUB_ENV"
           
       - name: Fetch storage key
         id: fetch-storage-key
         run: |
           AZURE_STORAGE_ACCOUNT_PASSWORD=$(az storage account keys list -g ${{ vars.AZURE_RG }} -n ${{ steps.bicep.outputs.storageAccountName }} | jq -r '.[0].value')
           echo "::add-mask::$AZURE_STORAGE_ACCOUNT_PASSWORD"
           echo "AZURE_STORAGE_ACCOUNT_PASSWORD=$AZURE_STORAGE_ACCOUNT_PASSWORD" >> "$GITHUB_ENV"
+          PUBLIC_IP_ADDRESS=$(az network public-ip show -g ${{ vars.AZURE_RG }} -n ${{ steps.bicep.outputs.publicIpName }} | jq -r '.ipAddress')
+          echo "::add-mask::$PUBLIC_IP_ADDRESS"
+          echo "PUBLIC_IP_ADDRESS=$PUBLIC_IP_ADDRESS" >> "$GITHUB_ENV"
 
       - name: Install Kubectl
         uses: azure/setup-kubectl@v3

diff --git a/config/prow/release-branch-jobs/1.24.yaml b/config/prow/release-branch-jobs/1.24.yaml
@@ -1,15 +1,4 @@
-periodics:
-- interval: 24h
-  agent: kubernetes
-  name: echo-test
-  namespace: test-pods
-  spec:
-    containers:
-      - image: alpine
-        command: ["/bin/date"]
-postsubmits: {}
-presubmits:
-  $GITHUB_ORG/$GITHUB_REPO:
+  # 1.24-lts jobs, do not change indentation of the lines below, it need to be aligned with base.yaml  
   - always_run: true
     branches:
     - release-1.24-lts