Merge pull request #64 from akazad13/feature/issue-63-implement-logger #31
akazad13Annotations
11 warnings
|
build
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
build:
src/Shopizy.Contracts/Category/CategoryTreeResponse.cs#L7
Change 'List<CategoryTreeResponse>' in 'CategoryTreeResponse.Children' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Contracts/Category/CategoryTreeResponse.cs#L7
Change 'List<CategoryTreeResponse>' in 'CategoryTreeResponse.CategoryTreeResponse(Guid, string, Guid?, List<CategoryTreeResponse>)' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Domain/Common/Models/IHasDomainEvents.cs#L6
Change 'List<IDomainEvent>' in 'IHasDomainEvents.PopDomainEvents()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Application/Payments/Commands/CashOnDeliverySale/CashOnDeliverySaleCommandHandler.cs#L64
The variable 'ex' is declared but never used
|
|
build:
src/Shopizy.Application/Payments/Commands/CardNotPresentSale/CardNotPresentSaleCommandHandler.cs#L120
The variable 'ex' is declared but never used
|
|
build:
src/Shopizy.Application/Categories/Queries/CategoriesTree/CategoryTree.cs#L8
Change 'List<CategoryTree>' in 'CategoryTree.Children' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Application/Common/models/CreateSaleRequest.cs#L9
Change 'List<string>' in 'CreateSaleRequest.PaymentMethodTypes' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Application/Common/models/CreateSaleResponse.cs#L17
Change 'List<string>' in 'CreateSaleResponse.PaymentMethodTypes' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
tests/UnitTests/Shopizy.Application.UnitTests/Auth/TestUtils/AuthFactory.cs#L8
Change 'List<Permission>' in 'AuthFactory.GetPermissions()' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|
|
build:
src/Shopizy.Contracts/Category/CategoryTreeResponse.cs#L7
Change 'List<CategoryTreeResponse>' in 'CategoryTreeResponse.Children' to use 'Collection<T>', 'ReadOnlyCollection<T>' or 'KeyedCollection<K,V>' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1002)
|