Merge pull request #721 from ramaces/patch-2

remove a tag with no link
ain · Mar 16, 2024 · 432115c · 432115c
2 parents 54bb5d9 + b4eab4f
commit 432115c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/smartbanner.js b/src/smartbanner.js
@@ -153,7 +153,7 @@ export default class SmartBanner {
   get html() {
     let modifier = !this.options.customDesignModifier ? this.platform : this.options.customDesignModifier;
     return `<div class="smartbanner smartbanner--${modifier} js_smartbanner">
-      <a href="javascript:void(0);" class="smartbanner__exit js_smartbanner__exit" aria-label="${this.closeLabel}"></a>
+      <span class="smartbanner__exit js_smartbanner__exit" aria-label="${this.closeLabel}"></span>
       <div class="smartbanner__icon" style="background-image: url(${this.icon});"></div>
       <div class="smartbanner__info">
         <div>

diff --git a/test/spec/smartbanner_spec.js b/test/spec/smartbanner_spec.js
@@ -183,7 +183,7 @@ describe('SmartBanner', function() {
   const HTML_WITH_JQUERY_MOBILE_AND_META = `<!doctype html><html>${HEAD}<body class="ui-page">${SCRIPTS_JQUERY_MOBILE}</body></html>`;
 
   const IOS_BODY = `<div class="smartbanner smartbanner--ios js_smartbanner">
-      <a href="javascript:void(0);" class="smartbanner__exit js_smartbanner__exit" aria-label="Close iOS Smart App Banner"></a>
+      <span class="smartbanner__exit js_smartbanner__exit" aria-label="Close iOS Smart App Banner"></span>
       <div class="smartbanner__icon" style="background-image: url(icon--apple.jpg);"></div>
       <div class="smartbanner__info">
         <div>
@@ -196,7 +196,7 @@ describe('SmartBanner', function() {
     </div>`;
 
   const ANDROID_BODY = `<div class="smartbanner smartbanner--android js_smartbanner">
-      <a href="javascript:void(0);" class="smartbanner__exit js_smartbanner__exit" aria-label="Close Android Smart App Banner"></a>
+      <span class="smartbanner__exit js_smartbanner__exit" aria-label="Close Android Smart App Banner"></span>
       <div class="smartbanner__icon" style="background-image: url(icon--google.jpg);"></div>
       <div class="smartbanner__info">
         <div>
@@ -209,7 +209,7 @@ describe('SmartBanner', function() {
     </div>`;
 
   const UNDEFINED_BODY = `<div class="smartbanner smartbanner--undefined js_smartbanner">
-      <a href="javascript:void(0);" class="smartbanner__exit js_smartbanner__exit" aria-label="Close Smart App Banner"></a>
+      <span class="smartbanner__exit js_smartbanner__exit" aria-label="Close Smart App Banner"></span>
       <div class="smartbanner__icon" style="background-image: url(icon--apple.jpg);"></div>
       <div class="smartbanner__info">
         <div>
@@ -222,7 +222,7 @@ describe('SmartBanner', function() {
     </div>`;
 
   const ANDROID_CUSTOM_DESIGN_BODY = `<div class="smartbanner smartbanner--custom-design js_smartbanner">
-      <a href="javascript:void(0);" class="smartbanner__exit js_smartbanner__exit" aria-label="Close banner"></a>
+      <span class="smartbanner__exit js_smartbanner__exit" aria-label="Close banner"></span>
       <div class="smartbanner__icon" style="background-image: url(icon--google.jpg);"></div>
       <div class="smartbanner__info">
         <div>