Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

FlorianStasse
Copy link

I updated some small parts both in keygen-rs and tauri-plugin-keygen-rs2 to make it work with Android:

  • I switched reqwest to the rustls feature which bypasses openssl (that is not easily available on Android)
  • I updated the build script for tauri-plugin-keygen-rs2 which was failling to build because it's not setup properly
  • I disabled machine_uid on the Android target, which make the "get_fingerprint" function return an empty string on Android, and the same value as before on other os.

I have developped a private tauri plugin to retrieve the machine id that wraps around machine_uid on desktop but uses some small kotlin code for Android (and I will add the required swift code for iOS). I may make it public in the coming months, so you might be able to use the plugin instead of directly calling machine_uid.

@ahonn
Copy link
Owner

ahonn commented Nov 12, 2024

I disabled machine_uid on the Android target, which make the "get_fingerprint" function return an empty string on Android, and the same value as before on other os.

This modification does not solve the issue. It will cause the machine fingerprint to be an empty string on Android, causing the deactivate/checkout machine to fail.

@ahonn
Copy link
Owner

ahonn commented Nov 12, 2024

I prefer to wait until you release this plugin before making relevant modifications to support Android/iOS.

@FlorianStasse
Copy link
Author

I won't be able to do it before a few weeks, I'll update this PR and ping you when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants