Upgrade TypeScript to 4.2

aduth · Mar 7, 2021 · 3d8ef1a · 3d8ef1a
1 parent d9b2fb1
commit 3d8ef1a
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 11 deletions.
diff --git a/background/providers.js b/background/providers.js
@@ -54,8 +54,8 @@ export const providers = {};
  * names for which authorization has changed to exist, not exist, or transition
  * to or from a state of error.
  *
- * @param {SLState} [prevState] Previous state, if exists.
- * @param {SLState} state       Next state.
+ * @param {SLState|undefined} prevState Previous state, if exists.
+ * @param {SLState}           state     Next state.
  *
  * @return {string[]} Provider names for changed authorizations.
  */

diff --git a/background/providers/twitch.js b/background/providers/twitch.js
@@ -320,7 +320,7 @@ export default /** @type {import('../providers').SLProvider} */ ( {
 			 ).flat();
 		}
 
-		const follows = await fetchFollows( auth.user.id );
+		const follows = await fetchFollows( /** @type {string} */ ( auth.user.id ) );
 		return fetchStreams( follows );
 	},
 } );
diff --git a/common/components/card.js b/common/components/card.js
@@ -44,6 +44,7 @@ function Card( { icon, title, children, className, buttonText, buttonOnClick } )
 		h( 'h4', { className: 'card__title' }, title ),
 		h( 'p', { className: 'card__description' }, children ),
 		buttonText &&
+			buttonOnClick &&
 			h(
 				'button',
 				{

diff --git a/common/components/notice.js b/common/components/notice.js
@@ -40,6 +40,7 @@ function Notice( { icon, text, buttonText, buttonOnClick, className } ) {
 			} ),
 		h( 'div', { className: 'notice__text' }, text ),
 		buttonText &&
+			buttonOnClick &&
 			h(
 				'button',
 				{

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -69,7 +69,7 @@
 		"prettier": "npm:wp-prettier@^2.0.5",
 		"rollup": "^2.26.0",
 		"rollup-plugin-sourcemaps": "^0.6.2",
-		"typescript": "^3.9.7",
+		"typescript": "^4.2.3",
 		"web-ext-types": "^3.2.1"
 	}
 }