-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace OOTB browser messages with constant strings #17
Conversation
|
shouldn't this be added along with the localisation change to keep the context why it was done. |
Wanted to keep things less cluttered. Localisation PR is not yet merged, I'll raise it once this is merged. |
According to the documentation, |
I also thought so, but it is not localised as per the page language. @ravise5 has confirmed that. |
* Replace OOTB browser messages with constant strings * Minor correction in testcase message --------- Co-authored-by: Ravisanker E <rae@adobe.com>
* Replace OOTB browser messages with constant strings * Minor correction in testcase message --------- Co-authored-by: Ravisanker E <rae@adobe.com>
Context:
The OOTB browser messages cannot be localised as they are not part of our code and these messages often vary from
browser to browser.
In this PR these browser validity messages are replaced by a set of fixed strings maintained in the
constants.js
file ,so that OOTB error messages are consistent across browsers and localisable.
cc: @vdua
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: