fixup! fixup! fixup! Add fine-grain ingress DNS control through CRD

adevinta · Dec 16, 2024 · 1d116fe · 1d116fe
1 parent 8de15fb
commit 1d116fe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/cmd/traffic-controller/main_test.go b/cmd/traffic-controller/main_test.go
@@ -199,6 +199,7 @@ func newIngressControllerService(loadbalancerName string) *v1.Service {
 			Selector: map[string]string{
 				"app": "my-service",
 			},
+			Type: v1.ServiceTypeLoadBalancer,
 			Ports: []v1.ServicePort{
 				{
 					Name: "http",

diff --git a/config/crd/bases/ingress.adevinta.com_clusteringressservicednsweights.yaml b/config/crd/bases/ingress.adevinta.com_clusteringressservicednsweights.yaml
@@ -17,7 +17,7 @@ spec:
   - name: v1beta1
     schema:
       openAPIV3Schema:
-        description: ClusterIngressServiceDNSWeight is the defines the links between
+        description: ClusterIngressServiceDNSWeight is what defines the links between
           k8s services and ingresses
         properties:
           apiVersion:

diff --git a/pkg/apis/ingress.adevinta.com/v1beta1/ingress_types.go b/pkg/apis/ingress.adevinta.com/v1beta1/ingress_types.go
@@ -4,7 +4,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )
 
-// ClusterIngressServiceDNSWeight is the defines the links between k8s services and ingresses
+// ClusterIngressServiceDNSWeight is what defines the links between k8s services and ingresses
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:scope=Cluster
 type ClusterIngressServiceDNSWeight struct {