-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: benchmark toy detector config #714
Conversation
188f804
to
67f2a91
Compare
This comment was marked as outdated.
This comment was marked as outdated.
67f2a91
to
9364b4f
Compare
6ed2e31
to
29b1033
Compare
29b1033
to
e791de9
Compare
|
70583ff
to
e3cd0d5
Compare
e3cd0d5
to
7f28d28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll think twice about asking for my review on the next PR. 😛
7f28d28
to
b904e52
Compare
b904e52
to
7a5833a
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks technically correct.
This PR seems to stop the continuous benchmark. |
Allow the toy detector grids to find all neighboring surfaces, this should increase the number of tracks that can be found and fitted. Furthermore, I restricted the simulation to an eta region, where the tracks should hit a decent number of sensitive surface. Apart from that, the detector is now copied to device instead of using managed memory.
Edit: I also remove the copy of the track states back to host containers and allowed openMP to use dynamic scheduling for better load balancing