Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: benchmark toy detector config #714

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Sep 24, 2024

Allow the toy detector grids to find all neighboring surfaces, this should increase the number of tracks that can be found and fitted. Furthermore, I restricted the simulation to an eta region, where the tracks should hit a decent number of sensitive surface. Apart from that, the detector is now copied to device instead of using managed memory.

Edit: I also remove the copy of the track states back to host containers and allowed openMP to use dynamic scheduling for better load balancing

@niermann999

This comment was marked as outdated.

@niermann999 niermann999 marked this pull request as ready for review October 8, 2024 14:52
@niermann999 niermann999 force-pushed the ref-benchmark-cfg branch 2 times, most recently from 6ed2e31 to 29b1033 Compare October 14, 2024 15:52
Copy link

@niermann999 niermann999 force-pushed the ref-benchmark-cfg branch 4 times, most recently from 70583ff to e3cd0d5 Compare February 7, 2025 12:06
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll think twice about asking for my review on the next PR. 😛

benchmarks/common/benchmarks/toy_detector_benchmark.hpp Outdated Show resolved Hide resolved
io/src/read_detector.cpp Outdated Show resolved Hide resolved
benchmarks/cuda/toy_detector_cuda.cpp Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Feb 7, 2025

@niermann999 niermann999 requested a review from krasznaa February 7, 2025 13:33
Copy link
Member

@krasznaa krasznaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks technically correct.

@niermann999 niermann999 merged commit 5a2372c into acts-project:main Feb 7, 2025
29 checks passed
@beomki-yeo
Copy link
Contributor

This PR seems to stop the continuous benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants