Error pages for more sections #2101
Conversation
|
Hey there 👋,
|
gnunicorn
requested review from
kumarpalsinh25,
bitfriend and
gtalha07
and removed request for
kumarpalsinh25
gnunicorn
added
bug
| @@ -148,6 +148,7 @@ dependencies: | |||
| open_filex: ^4.5.0 | |||
| phosphor_flutter: ^2.1.0 | |||
| device_calendar: ^4.3.2 | |||
| quickalert: ^1.1.0 | |||
There was a problem hiding this comment.
Aren't we using EasyLoading package to show different data states? Why this one is needed on top??
There was a problem hiding this comment.
easyloading is transative, dialog-oriented and non-disruptive. quickalert provides further widget for more prominent, larger and more intrusive widgets. They are complementary.
There was a problem hiding this comment.
If that is so, do we want to consider unify all alerts be approached according to this package? If it also supports loading/error states?
There was a problem hiding this comment.
no. they are complementary, covering different aspects. I think we want to keep easyloading as is. only errors and interactions we want the user to be forced to deal with, this is for.
| import '../../helpers/test_util.dart'; | ||
|
|
||
| void main() { | ||
| group('Event List Error Pages', () { |
There was a problem hiding this comment.
Protests! More like pro tests 😄 👏🏻
With tests, on top of #2089 of course.
Additionally this refactors the
AsyncRsvpStatusNotifierinto a typed variant that uses theRsvpStatusTagas it should be done.