Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more testing to dicom archive loader last commit #1247

Merged

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Mar 21, 2025

Description

This adds the following tests to test_run_dicom_archive_loader.py:

  • test invalid argument provided to the script
  • test tarchive_path that does not exist
  • test invalid UploadID provided
  • addition of some checks post successful run:
    • check mri_upload.number_of_minc_inserted is correct
    • check mri_upload.number_of_minc_created is correct
    • check dicom_archive.session_id has been set
    • check location of the archive after it has been moved to year subfolder
    • check mri_upload.insertion_complete is set to True

It also modifies the DICOMs on the S3 bucket and the entries in the tarchive tables to add the localizer to the T1W to check that the localizer is indeed skipped because it is part of the series to exclude in the configuration setting excluded_series_description.

Replaces #1244 that was polluted by a force-push

@cmadjar cmadjar added this to the 27.0 milestone Mar 21, 2025
@cmadjar cmadjar added the Area: CI PR or issue related to continuous integration, including automated tests and static checks label Mar 21, 2025
@cmadjar cmadjar merged commit f26e5aa into aces:main Mar 21, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: CI PR or issue related to continuous integration, including automated tests and static checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant