MG-2117 - Remove repository errors from API layer #2119

WashingtonKK · 2024-03-19T15:32:31Z

What type of PR is this?

This is a feature that removes removes repository errors from the api response and only the service error and api errors are sent as part of the response. All errors are logged and can be evaluated from the service logs.

What does this do?

Ensures only errors from the service and api are sent as part of the API response, and leaves repo errors at service level.

Which issue(s) does this PR fix/relate to?

Resolves Feature: Remove repository error in API response #2117
Related to Refactoring Error Handling & Return Varaibles #1998

Have you included tests for your changes?

No

Did you document any new/modified feature?

No

Notes

users/service.go

things/service.go

users/service.go

auth/service_test.go

arvindh123 · 2024-04-03T10:26:39Z

@WashingtonKK

In users/service.go repoerr are returned by service function ,
Could you please change to respective service error and handle them as you did for other service

things/service.go

things/service_test.go

users/service.go

arvindh123

@WashingtonKK ,
Please revert back to original, My suggestion doesn't works properly for domain related operations
It fails at domain authroization

auth/service.go

dborovcanin · 2024-04-29T13:38:09Z

auth/service_test.go

@@ -231,9 +248,15 @@ func TestIssue(t *testing.T) {
 				ObjectType:  auth.DomainType,
 				Permission:  auth.MembershipPermission,
 			},
+			checkPolicyRequest2: auth.PolicyReq{


Rename checkPolicyRequest fields to add more context. For example checkPolicyReq and checkPolicyWithStatusReq.

internal/api/common.go

arvindh123

LGTM

users/service.go

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Remove repoerr from things service Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Remove repoerr in services Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Fix ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Add servive error check Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Wrap permission list error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Wrap permission list error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Modify tests and keep internal errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Fix tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: enhance error encoding Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: update api docs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> feat: update checkdomain and checkpolicy Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: errors on service layer Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: property based tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Remove repo error from service layer Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix test' Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor errors: Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: property based tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> enhance errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> remove unused error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update bootstrap and certs tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Update docs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> update bootstrap test Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix auth tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix typo: Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: certs and twins tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: issue token Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor error handling and fix tests: Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix tests and remove redundant error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Update users/service.go Co-authored-by: Arvindh <30824765+arvindh123@users.noreply.github.com> Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> modify delete policies error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert error types Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: ci Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert policy rollback error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> revert domain check Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> remove debug logs Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix bootstrap property based tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor bootstrap service error Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

WashingtonKK self-assigned this Mar 19, 2024

WashingtonKK closed this Mar 20, 2024

WashingtonKK force-pushed the repo-err-fix branch from e18db8e to ec7b4b4 Compare March 20, 2024 07:45

WashingtonKK reopened this Mar 20, 2024

arvindh123 reviewed Mar 20, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 20, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 20, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 20, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 20, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 21, 2024

View reviewed changes

things/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Mar 21, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

WashingtonKK marked this pull request as ready for review March 22, 2024 08:44

WashingtonKK requested a review from arvindh123 March 22, 2024 08:44

arvindh123 added this to the S1 milestone Mar 25, 2024

WashingtonKK force-pushed the repo-err-fix branch 2 times, most recently from 33bd7ef to 5916549 Compare March 25, 2024 14:55

WashingtonKK mentioned this pull request Mar 26, 2024

Refactoring Error Handling & Return Varaibles #1998

Closed

WashingtonKK linked an issue Mar 26, 2024 that may be closed by this pull request

Refactoring Error Handling & Return Varaibles #1998

Closed

dborovcanin changed the title ~~MG-2117 - Remove repo error in API response~~ MG-2117 - Remove repository errors from API layer Mar 26, 2024

dborovcanin force-pushed the repo-err-fix branch from 5916549 to 00cda2c Compare March 26, 2024 10:27

WashingtonKK force-pushed the repo-err-fix branch from 00cda2c to b50c998 Compare April 2, 2024 07:07

arvindh123 reviewed Apr 3, 2024

View reviewed changes

auth/service_test.go Show resolved Hide resolved

dborovcanin modified the milestones: S1, S2 Apr 3, 2024

WashingtonKK force-pushed the repo-err-fix branch from b50c998 to 00134ae Compare April 3, 2024 13:53

rodneyosodo requested changes Apr 4, 2024

View reviewed changes

things/service.go Show resolved Hide resolved

things/service.go Show resolved Hide resolved

things/service.go Show resolved Hide resolved

things/service.go Show resolved Hide resolved

things/service_test.go Show resolved Hide resolved

users/service.go Show resolved Hide resolved

WashingtonKK force-pushed the repo-err-fix branch 3 times, most recently from 5ca3fe8 to 0074cc3 Compare April 9, 2024 06:59

WashingtonKK force-pushed the repo-err-fix branch 2 times, most recently from 1712df9 to 013b104 Compare April 26, 2024 07:23

arvindh123 reviewed Apr 26, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

arvindh123 requested changes Apr 26, 2024

View reviewed changes

auth/service.go Outdated Show resolved Hide resolved

arvindh123 reviewed Apr 26, 2024

View reviewed changes

auth/service.go Outdated Show resolved Hide resolved

dborovcanin requested changes Apr 29, 2024

View reviewed changes

arvindh123 reviewed Apr 29, 2024

View reviewed changes

internal/api/common.go Outdated Show resolved Hide resolved

WashingtonKK force-pushed the repo-err-fix branch from 3b0c289 to 4fa7488 Compare April 30, 2024 04:44

arvindh123 force-pushed the repo-err-fix branch from 532e049 to 3f4bcd6 Compare April 30, 2024 09:10

arvindh123 previously approved these changes Apr 30, 2024

View reviewed changes

rodneyosodo requested changes Apr 30, 2024

View reviewed changes

users/service.go Outdated Show resolved Hide resolved

WashingtonKK dismissed arvindh123’s stale review via bf18d95 April 30, 2024 12:59

rodneyosodo approved these changes Apr 30, 2024

View reviewed changes

arvindh123 approved these changes May 7, 2024

View reviewed changes

dborovcanin force-pushed the repo-err-fix branch from bf18d95 to b09990a Compare May 8, 2024 09:57

WashingtonKK added 8 commits May 10, 2024 10:31

update auth api docs

5efad4d

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> refactor errors Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: certs and twins tests

a343321

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> fix: certs and twins tests Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix ci

b527df3

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

refactor test cases

4012c94

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

fix: ci

7d32302

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

update oauth error

c2176d9

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

dborovcanin force-pushed the repo-err-fix branch from b09990a to c2176d9 Compare May 10, 2024 08:31

dborovcanin approved these changes May 10, 2024

View reviewed changes

dborovcanin merged commit 75db28c into absmach:main May 10, 2024
6 checks passed

WashingtonKK deleted the repo-err-fix branch May 10, 2024 13:27

JeffMboya pushed a commit to JeffMboya/supermq that referenced this pull request May 15, 2024

MG-2117 - Remove repository errors from API layer (absmach#2119)

54f7dd9

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>

JeffMboya pushed a commit to JeffMboya/supermq that referenced this pull request May 15, 2024

MG-2117 - Remove repository errors from API layer (absmach#2119)

fd073b2

Signed-off-by: WashingtonKK <washingtonkigan@gmail.com> Signed-off-by: JeffMboya <jangina.mboya@gmail.com>

andychao217 pushed a commit to andychao217/magistrala that referenced this pull request Sep 23, 2024

MG-2117 - Remove repository errors from API layer (absmach#2119)

f4027b0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MG-2117 - Remove repository errors from API layer #2119

MG-2117 - Remove repository errors from API layer #2119

WashingtonKK commented Mar 19, 2024 •

edited

Loading

arvindh123 commented Apr 3, 2024

arvindh123 left a comment

dborovcanin Apr 29, 2024

arvindh123 left a comment

MG-2117 - Remove repository errors from API layer #2119

MG-2117 - Remove repository errors from API layer #2119

Conversation

WashingtonKK commented Mar 19, 2024 • edited Loading

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

arvindh123 commented Apr 3, 2024

arvindh123 left a comment

Choose a reason for hiding this comment

dborovcanin Apr 29, 2024

Choose a reason for hiding this comment

arvindh123 left a comment

Choose a reason for hiding this comment

WashingtonKK commented Mar 19, 2024 •

edited

Loading