This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
suggested changes
Nov 14, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
suggested changes
Nov 14, 2023
rodneyosodo
suggested changes
Nov 14, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
suggested changes
Nov 15, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
reviewed
Nov 15, 2023
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
dborovcanin
approved these changes
Nov 15, 2023
rodneyosodo
suggested changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the CI workflow add a stage for build docker image but don't push the images. Before running tests. SOmething like
- name: Build docker images
# if: github.event_name == 'pull_request'
run: |
go mod vendor
make dockers -j $(nproc)
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
rodneyosodo
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dborovcanin
approved these changes
Nov 20, 2023
Musilah
pushed a commit
that referenced
this pull request
Dec 17, 2023
* add templates Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix gci linting errors Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix typo Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * add prettier to ci Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix ci.yml file Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update copyright Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update check license excluded files Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix dependabot Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix makefile Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * fix makefile compile service Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update ordering Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> * update docker files Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com> --------- Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
None
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes