Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

NOISSUE- Add Templates and Fix linting #4

Merged
merged 12 commits into from
Nov 20, 2023
Merged

NOISSUE- Add Templates and Fix linting #4

merged 12 commits into from
Nov 20, 2023

Conversation

ianmuchyri
Copy link
Contributor

What does this do?

  • Add golangci lint config
  • Add Issue and PR templates
  • Modify CI to use make where possible

Which issue(s) does this PR fix/relate to?

None

List any changes that modify/break current functionality

None

Have you included tests for your changes?

No

Did you document any new/modified functionality?

No

Notes

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
.github/dependabot.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
.github/dependabot.yml Outdated Show resolved Hide resolved
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
.github/dependabot.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the CI workflow add a stage for build docker image but don't push the images. Before running tests. SOmething like

      - name: Build docker images
      # if: github.event_name == 'pull_request'
        run: |
          go mod vendor
          make dockers -j $(nproc)

Makefile Show resolved Hide resolved
Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Copy link
Member

@rodneyosodo rodneyosodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit 72e2e84 into main Nov 20, 2023
@dborovcanin dborovcanin deleted the addtemplate branch November 20, 2023 09:08
Musilah pushed a commit that referenced this pull request Dec 17, 2023
* add templates

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix gci linting errors

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix typo

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* add prettier to ci

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix ci.yml file

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update copyright

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update check license excluded files

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix dependabot

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix makefile

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* fix makefile compile service

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update ordering

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

* update docker files

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>

---------

Signed-off-by: ianmuchyri <ianmuchiri8@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants