-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MG-143 - auto-generate Markdown documentation from Helm charts #144
Merged
+62
−8
Merged
Changes from 24 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
d819021
feat: Package MG helm chart
JeffMboya 3209c96
feat: Add index.yaml file
JeffMboya b537215
feat: remove index.yaml
JeffMboya f279060
feat: add charts_dir
JeffMboya 959d9a1
feat: Add config file for helm chart-releaser-action
JeffMboya 7200319
feat: Add dependecies to release.yaml
JeffMboya 5b9d3be
feat: Add lint-test and reusable workflow
JeffMboya 1e640e7
Feat: Add helm-docs.yaml
JeffMboya 6acae9e
fix CI
JeffMboya db06002
remove unnecessary file
JeffMboya 9d2deaa
fix CI
JeffMboya 5dd7597
Update workflow to point to master and all branches
JeffMboya f6a7550
Update helm-docs workflow
JeffMboya 0a9f77a
Update helm-docs workflow
JeffMboya 05d40a5
Update helm-docs workflow
JeffMboya 299b9dd
Update helm-docs workflow
JeffMboya 111e8a2
Update helm-docs workflow
JeffMboya cd94aaf
run on PR on all branches with norwoodj/helm-docs
JeffMboya 1931a90
test norwoodj/helm-docs
JeffMboya 506aafa
update README
JeffMboya 9ab8a48
view CI logs
JeffMboya 83153b3
view CI logs
JeffMboya 54e8e6b
add README.md.gotmpl
JeffMboya 003e7da
Update workflow to fail on diff
JeffMboya ed27c1a
Limit Helm docs to master
JeffMboya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
name: Generate Helm Docs | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- '*' # Run on all pull requests | ||
|
||
jobs: | ||
generate-docs: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
with: | ||
repository: ${{ github.event.pull_request.head.repo.full_name }} | ||
ref: ${{ github.event.pull_request.head.ref }} | ||
fetch-depth: 0 | ||
|
||
- name: Generate Helm Docs | ||
uses: losisin/helm-docs-github-action@v1.3.1 | ||
with: | ||
chart-search-root: "charts/magistrala" | ||
values-file: "values.yaml" | ||
output-file: "README.md" | ||
template-files: "README.md.gotmpl" | ||
git-push: false | ||
fail-on-diff: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
{{ template "chart.header" . }} | ||
|
||
{{ template "chart.description" . }} | ||
|
||
{{ template "chart.badgesSection" . }} | ||
|
||
{{ template "chart.homepageLine" . }} | ||
|
||
{{ template "chart.maintainersSection" . }} | ||
|
||
{{ template "chart.sourcesSection" . }} | ||
|
||
{{ template "chart.requirementsSection" . }} | ||
|
||
{{ template "chart.valuesSection" . }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add an empty line. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this wildcard even necessary? Do we want it on PR or on each push?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dborovcanin this was for testing purposes. Ideally, we want to run the workflow on a push to
master
to ensures that Helm docs are only generated for finalized, merged code