-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Do not leak codefix IDs in API #1775
base: main
Are you sure you want to change the base?
Fix: Do not leak codefix IDs in API #1775
Conversation
Hey @Dedsec0098, Great to see your enthusiasm for contributing! It’s awesome that you’re actively working on PRs. Just wanted to share a few tips that might help make your contributions even more impactful: Now, moving on to some specific review points for this PR… |
Hi @Rishi-source thanks a lot for sharing me your views, I totally get your point and would definitely start putting test results in my PRs. |
@Dedsec0098 please add tests, rest it looks good. Thanks! |
Sure @TG1999 , I'll start working on adding tests |
Hey @TG1999 I have added tests to my PR, please let me know if I have done it correctly or some changes are needed. |
@@ -0,0 +1,46 @@ | |||
import re |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add license headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TG1999 I have made the changes to add headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing pls check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TG1999 I am finding it difficult to solve these tests issues, but i am trying to solve them as soon as possible.
Signed-off-by: Shrish0098 <shrish409@gmail.com>
Signed-off-by: Shrish0098 <shrish409@gmail.com>
Signed-off-by: Shrish0098 <shrish409@gmail.com>
5762915
to
ab7f19d
Compare
Fix #1752
Added uuid instead of using id
Imported uuid in the model.py
Added test_codefix_id under tests section
Signed-off-by: Shrish Mishra shrish409@gmail.com