Skip to content

Commit

Permalink
Merge pull request #14 from abordage/laravel-10
Browse files Browse the repository at this point in the history
Laravel 10 support
  • Loading branch information
abordage authored Feb 25, 2023
2 parents 36cb45f + 6802f40 commit 7392f99
Show file tree
Hide file tree
Showing 8 changed files with 84 additions and 10 deletions.
54 changes: 54 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Bug Report
description: Report a general package issue. Filling in the issue template is mandatory, issues without it will be closed.
title: "[Bug]: "
labels: [ bug ]
body:
- type: checkboxes
id: terms
attributes:
label: Is the bug applicable and reproducible to the latest version of the package and hasn't it been reported before?
options:
- label: Yes, it's still reproducible
required: true
- type: input
attributes:
label: What version of Package are you using?
description: 'For example: 1.2.0'
validations:
required: true
- type: input
attributes:
label: What version of Laravel are you using?
description: 'For example: 9.52.0'
validations:
required: true
- type: input
attributes:
label: What version of Laravel Nova are you using?
description: 'For example: 4.22.1'
validations:
required: true
- type: input
attributes:
label: What version of PHP are you using?
description: 'For example: 8.1.0'
validations:
required: true
- type: textarea
attributes:
label: Describe your issue
description: Describe the problem you're seeing, Please be short, but concise.
validations:
required: true
- type: textarea
attributes:
label: How can the issue be reproduced?
description: Please provide easy-to-reproduce steps (repository, simple code example, failing unit test).
validations:
required: true
- type: textarea
attributes:
label: What should be the expected behaviour?
description: Please describe what the expected outcome should be. Any suggestions to what is wrong?
validations:
required: true
6 changes: 0 additions & 6 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,3 @@ contact_links:
- name: Request a feature
url: https://github.com/abordage/nova-table-card/discussions/new?category=ideas
about: Share ideas for new features
- name: Report a bug
url: https://github.com/abordage/nova-table-card/issues/new
about: Report a reproducible bug
- name: Report a security issue
url: https://github.com/abordage/nova-table-card/security/policy
about: Learn how to notify us for sensitive bugs
18 changes: 18 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.


> 💡 Please take note of our [contributing guidelines](https://github.com/abordage/.github/blob/master/CONTRIBUTING.md)
1. Why should it be added? What are the benefits of this change?
2. Does it contain multiple, unrelated changes? Please separate the PRs out.
3. Does it include tests, if possible?
4. Any drawbacks? Possible breaking changes?

**Mark the following tasks as done:**
- [ ] Checked the codebase to ensure that your feature doesn't already exist.
- [ ] Take note of the contributing guidelines.
- [ ] Checked the pull requests to ensure that another person hasn't already submitted a fix.
- [ ] Added tests to ensure against regression.
- [ ] Updated the changelog

### Thanks for contributing!
2 changes: 2 additions & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

$finder = Symfony\Component\Finder\Finder::create()
->in([
__DIR__ . '/src'
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!--suppress HtmlDeprecatedAttribute -->

# Nova Table Card

A Laravel Nova card for displaying lists with links to view and edit.
Expand Down Expand Up @@ -40,7 +42,7 @@ A Laravel Nova card for displaying lists with links to view and edit.
</p>

## Requirements
- PHP 7.4 or higher
- PHP 7.4 - 8.2
- Nova 4

## Installation
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.0",
"nunomaduro/collision": "^5.0 || ^6.0",
"nunomaduro/collision": "^5.0 || ^6.0 || ^7.0",
"nunomaduro/larastan": "^1.0 || ^2.0",
"orchestra/testbench": "^6.0 || ^7.0",
"orchestra/testbench": "^6.0 || ^7.0 || ^8.0",
"phpstan/phpstan": "^1.0",
"phpunit/phpunit": "^9.5"
"phpunit/phpunit": "^9.6 || ^10.0"
},
"minimum-stability": "dev",
"prefer-stable": true,
Expand Down
2 changes: 2 additions & 0 deletions src/CardServiceProvider.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

namespace Abordage\TableCard;

use Abordage\TableCard\Console\CardCommand;
Expand Down
2 changes: 2 additions & 0 deletions src/TableCard.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
<?php

declare(strict_types=1);

namespace Abordage\TableCard;

use Illuminate\Database\Eloquent\Model;
Expand Down

0 comments on commit 7392f99

Please sign in to comment.